mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #7388] [MERGED] Hide ISO 639-2 special codes in display titles #11372
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/7388
Author: @GermanCoding
Created: 3/1/2022
Status: ✅ Merged
Merged: 3/5/2022
Merged by: @crobibero
Base:
master← Head:iso639-undefined📝 Commits (2)
e09641bHide ISO 639-2 special codes in display titles3f6a14eUse extension method for list search📊 Changes
1 file changed (+15 additions, -1 deletions)
View changed files
📝
MediaBrowser.Model/Entities/MediaStream.cs(+15 -1)📄 Description
This has bugged me for a while now.
Jellyfin shows the language for audio streams, if it is present in metadata. This is great and correct.
However, there are audio streams that make use of ISO 639-2 special codes. Those then look like this:
"und" is ISO-special for undetermined, which is confusing for users (especially as "und" is also a word in german). Generally I think some of these specials are rarely known, e.g who knows that "zxx" is "no linguistic content; not applicable".
Therefore I believe having these specials displayed prominently in display titles is wrong. I get that there is still value in displaying this information - it's technical data that may be of interest to more technical users. Hence I did not remove language codes displaying from metadata - just from the display title.
Not it looks like this, much cleaner IMHO:
Language codes are still shown in associated metadata:
There are also more language codes that Jellyfin currently can't expand (ISO 639-2 B codes for example), but here I think that there is still value in displaying them, hence they are not filtered. It's just the specials that cause more confusion than providing information to users.
Changes
Filters ISO639-2 special codes (except the reserved range - whoever uses that hopefully knows what they're doing) from display titles.
Testing
As shown in the screenshots above, manually verified that this works as intended.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.