starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #7379] [MERGED] Add hearing impaired subtitle stream indicator #11370

New Issue
Closed
opened 2026-02-07 06:37:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:37:15 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/7379
Author: @1337joe
Created: 3/1/2022
Status: ✅ Merged
Merged: 10/7/2022
Merged by: @Bond-009

Base: master ← Head: add-hearing-impaired

📝 Commits (3)

  • be769a0 Add hearing impaired flag
  • 2be7491 Support hearing impaired flag for external files
  • 40236ab Merge branch 'master' into add-hearing-impaired

📊 Changes

13 files changed (+102 additions, -12 deletions)

View changed files

📝 Emby.Naming/Common/NamingOptions.cs (+12 -0)
📝 Emby.Naming/ExternalFiles/ExternalPathParser.cs (+12 -0)
📝 Emby.Naming/ExternalFiles/ExternalPathParserResult.cs (+9 -1)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+11 -2)
📝 Emby.Server.Implementations/Localization/Core/en-US.json (+1 -0)
📝 MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs (+6 -0)
📝 MediaBrowser.Model/Entities/MediaStream.cs (+13 -0)
📝 MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs (+1 -0)
📝 tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs (+4 -0)
📝 tests/Jellyfin.MediaEncoding.Tests/Test Data/Probing/video_mp4_metadata.json (+1 -1)
📝 tests/Jellyfin.Model.Tests/Entities/MediaStreamTests.cs (+13 -0)
📝 tests/Jellyfin.Naming.Tests/ExternalFiles/ExternalPathParserTests.cs (+10 -1)
📝 tests/Jellyfin.Providers.Tests/MediaInfo/MediaInfoResolverTests.cs (+9 -7)

📄 Description

This is my first time touching the database contents, definitely let me know if anything there looks questionable.

Changes

  • Add a flag to media stream to indicate the stream is for hearing impaired users
    • Flag source: ffprobe hearing_impaired disposition, "sdh"/"hi"/"cc" in external stream file name
    • Flag use: Add localized "Hearing Impaired" indicator when selecting subtitle stream

Issues
Fixes #4291

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/7379 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 3/1/2022 **Status:** ✅ Merged **Merged:** 10/7/2022 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `add-hearing-impaired` --- ### 📝 Commits (3) - [`be769a0`](https://github.com/jellyfin/jellyfin/commit/be769a0fa0ea961dcbdb2f7e7fa58af17a2248d1) Add hearing impaired flag - [`2be7491`](https://github.com/jellyfin/jellyfin/commit/2be7491f40668d074e0d5f8b9737dfa912d464ad) Support hearing impaired flag for external files - [`40236ab`](https://github.com/jellyfin/jellyfin/commit/40236ab70f6da8d285901ca2929a2094039827cf) Merge branch 'master' into add-hearing-impaired ### 📊 Changes **13 files changed** (+102 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Common/NamingOptions.cs` (+12 -0) 📝 `Emby.Naming/ExternalFiles/ExternalPathParser.cs` (+12 -0) 📝 `Emby.Naming/ExternalFiles/ExternalPathParserResult.cs` (+9 -1) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+11 -2) 📝 `Emby.Server.Implementations/Localization/Core/en-US.json` (+1 -0) 📝 `MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs` (+6 -0) 📝 `MediaBrowser.Model/Entities/MediaStream.cs` (+13 -0) 📝 `MediaBrowser.Providers/MediaInfo/MediaInfoResolver.cs` (+1 -0) 📝 `tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs` (+4 -0) 📝 `tests/Jellyfin.MediaEncoding.Tests/Test Data/Probing/video_mp4_metadata.json` (+1 -1) 📝 `tests/Jellyfin.Model.Tests/Entities/MediaStreamTests.cs` (+13 -0) 📝 `tests/Jellyfin.Naming.Tests/ExternalFiles/ExternalPathParserTests.cs` (+10 -1) 📝 `tests/Jellyfin.Providers.Tests/MediaInfo/MediaInfoResolverTests.cs` (+9 -7) </details> ### 📄 Description This is my first time touching the database contents, definitely let me know if anything there looks questionable. **Changes** - Add a flag to media stream to indicate the stream is for hearing impaired users - Flag source: ffprobe `hearing_impaired` disposition, "sdh"/"hi"/"cc" in external stream file name - Flag use: Add localized "Hearing Impaired" indicator when selecting subtitle stream **Issues** Fixes #4291 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:37:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?