[PR #7363] [MERGED] Parse the unused chapter id field from ffmpeg output as a long #11361

Closed
opened 2026-02-07 06:37:05 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/7363
Author: @1337joe
Created: 2/27/2022
Status: Merged
Merged: 3/1/2022
Merged by: @Bond-009

Base: masterHead: ffmpeg-5-long-chapter-id


📝 Commits (1)

  • 175ddff Switch chapter id to long to not break on ffmpeg 5.0

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 MediaBrowser.MediaEncoding/Probing/MediaChapter.cs (+1 -1)

📄 Description

ffmpeg 5.0 is producing values well outside the range of an int in the chapter id field. From the linked issue:

"chapters": [
        {
            "id": 251446668167383985,
            "time_base": "1/1000000000",
            "start": 0,
            "start_time": "0.000000",
            "end": 99766333333,
            "end_time": "99.766333"
        },

The Id field only exists in jellyfin to parse the json output: it's not used in any way downstream (see here for the use of MediaChapter).

Changes

  • Parse the unused chapter id from ffmpeg output of as a long

Issues
Fixes #7355


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/7363 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 2/27/2022 **Status:** ✅ Merged **Merged:** 3/1/2022 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `ffmpeg-5-long-chapter-id` --- ### 📝 Commits (1) - [`175ddff`](https://github.com/jellyfin/jellyfin/commit/175ddff169411f8b4f202784839d5b4998031537) Switch chapter id to long to not break on ffmpeg 5.0 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.MediaEncoding/Probing/MediaChapter.cs` (+1 -1) </details> ### 📄 Description ffmpeg 5.0 is producing values well outside the range of an int in the chapter id field. From the linked issue: ``` "chapters": [ { "id": 251446668167383985, "time_base": "1/1000000000", "start": 0, "start_time": "0.000000", "end": 99766333333, "end_time": "99.766333" }, ``` The `Id` field only exists in jellyfin to parse the json output: it's not used in any way downstream (see [here](https://github.com/jellyfin/jellyfin/blob/e26446f9c06d23d483d7c3db40888d51d37fdcdc/MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs#L1433) for the use of `MediaChapter`). **Changes** - Parse the unused chapter id from ffmpeg output of as a long **Issues** Fixes #7355 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:37:05 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11361