mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #7153] [MERGED] Increase timeout for subtitle extraction to 30min #11290
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/7153
Author: @vgambier
Created: 1/10/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @Bond-009
Base:
master← Head:subtitle-timeout📝 Commits (1)
7e75a01Increase timeout for subtitle extraction to 30min📊 Changes
2 files changed (+2 additions, -1 deletions)
View changed files
📝
CONTRIBUTORS.md(+1 -0)📝
MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs(+1 -1)📄 Description
Changes
Increase timeout value for subtitle extraction operation from 5 minutes to 30 minutes. In some cases, ffmpeg takes over 5 minutes to extract the subtitle even though nothing is wrong with the file and the extraction is possible.
Arguably the fact that some video files take this long might indicate that this extraction step should be (optionally?) done in advance, otherwise there will be 5 to 30 minutes of the file playing without subtitles.
Issues
Addresses #6672
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.