starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #7148] [CLOSED] Fix #7147: Don't return subtitles in mismatched format #11283

New Issue
Closed
opened 2026-02-07 06:35:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:35:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/7148
Author: @SenorSmartyPants
Created: 1/9/2022
Status: ❌ Closed

Base: master ← Head: Subtitles

📝 Commits (4)

  • bd2bec4 Remove special HTTP HEAD processing
  • 3ea54a8 Remove isHeadRequest from GetStaticFile method signatures
  • d5e7e75 Remove unused httpContext parameter
  • a8306cb Fix #7147: Don't return subtitles in mismatched format

📊 Changes

7 files changed (+22 additions, -75 deletions)

View changed files

📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/HlsSegmentController.cs (+2 -2)
📝 Jellyfin.Api/Controllers/ImageController.cs (+14 -37)
📝 Jellyfin.Api/Controllers/VideosController.cs (+2 -4)
📝 Jellyfin.Api/Helpers/AudioHelper.cs (+2 -4)
📝 Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs (+1 -21)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs (+0 -6)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/7148 **Author:** [@SenorSmartyPants](https://github.com/SenorSmartyPants) **Created:** 1/9/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Subtitles` --- ### 📝 Commits (4) - [`bd2bec4`](https://github.com/jellyfin/jellyfin/commit/bd2bec4d4aedb1e39082d51abd75797eaf42b28a) Remove special HTTP HEAD processing - [`3ea54a8`](https://github.com/jellyfin/jellyfin/commit/3ea54a8009617998e7250a39e33a9da3440a9631) Remove isHeadRequest from GetStaticFile method signatures - [`d5e7e75`](https://github.com/jellyfin/jellyfin/commit/d5e7e754215d5e2d83e53e8a7898c01195c0d5b3) Remove unused httpContext parameter - [`a8306cb`](https://github.com/jellyfin/jellyfin/commit/a8306cbdabeb84ca25967dae72a703dfd01bd2d5) Fix #7147: Don't return subtitles in mismatched format ### 📊 Changes **7 files changed** (+22 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/HlsSegmentController.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+14 -37) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+2 -4) 📝 `Jellyfin.Api/Helpers/AudioHelper.cs` (+2 -4) 📝 `Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs` (+1 -21) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs` (+0 -6) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:35:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?