starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #7039] [MERGED] Providermanager cleanup #11237

New Issue
Closed
opened 2026-02-07 06:34:51 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:34:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/7039
Author: @1337joe
Created: 12/24/2021
Status: ✅ Merged
Merged: 11/23/2022
Merged by: @Bond-009

Base: master ← Head: providermanager-cleanup

📝 Commits (10+)

  • 2e2a594 Move Get*Providers definitions to interface
  • 4ace7f5 Fix unused var, log typo
  • 785cc1b Implement sort test for ProviderManager.GetImageProviders
  • 8515e8f Improve image provider sorting
  • 6221991 Add nullable annotations
  • 56900d0 Implement CanRefresh tests for ProviderManager.GetImageProviders
  • 11c7c24 Clarify naming, minor method ordering improvement
  • 91e706d Implement sort test for ProviderManager.GetMetadataProviders
  • e7df72d Improve metadata provider sorting
  • d5e2c2f Implement CanRefreshMetadata tests for GetMetadataProviders

📊 Changes

8 files changed (+776 additions, -225 deletions)

View changed files

📝 MediaBrowser.Controller/BaseItemManager/BaseItemManager.cs (+6 -8)
📝 MediaBrowser.Controller/BaseItemManager/IBaseItemManager.cs (+4 -4)
📝 MediaBrowser.Controller/Providers/IMetadataService.cs (+5 -0)
📝 MediaBrowser.Controller/Providers/IProviderManager.cs (+18 -0)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+2 -2)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+115 -191)
📝 tests/Jellyfin.Controller.Tests/BaseItemManagerTests.cs (+12 -20)
➕ tests/Jellyfin.Providers.Tests/Manager/ProviderManagerTests.cs (+614 -0)

📄 Description

A bunch of incremental improvements to ProviderManager.cs and related files, primarily focusing on RefreshSingleItem, GetImageProviders, and GetMetadataProviders.

Changes

  • Pulled a couple public methods up to the interface, resolved #nullable disable, general minor cleanup
  • Stored library type options and fetcher order logic up front instead of rechecking multiple times for each provider
  • Merged and simplified similar/duplicated code for image and metadata sorting
  • Added unit tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/7039 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 12/24/2021 **Status:** ✅ Merged **Merged:** 11/23/2022 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `providermanager-cleanup` --- ### 📝 Commits (10+) - [`2e2a594`](https://github.com/jellyfin/jellyfin/commit/2e2a594e19038bc2fcea5fdbeda9d37e8394fff7) Move Get*Providers definitions to interface - [`4ace7f5`](https://github.com/jellyfin/jellyfin/commit/4ace7f5c532b655449f7121b660a2cb9e66570be) Fix unused var, log typo - [`785cc1b`](https://github.com/jellyfin/jellyfin/commit/785cc1bb6ed1cbd3d0c300b9842af6e15167e715) Implement sort test for ProviderManager.GetImageProviders - [`8515e8f`](https://github.com/jellyfin/jellyfin/commit/8515e8fbd111278cad95430e50904d6721be3a63) Improve image provider sorting - [`6221991`](https://github.com/jellyfin/jellyfin/commit/6221991c630bcbd688316ad35121781c7a52c591) Add nullable annotations - [`56900d0`](https://github.com/jellyfin/jellyfin/commit/56900d0fc3bc791fd3c0a92bda22ca2f23f28be1) Implement CanRefresh tests for ProviderManager.GetImageProviders - [`11c7c24`](https://github.com/jellyfin/jellyfin/commit/11c7c24f0ef06e6366c075062928976ae0d30600) Clarify naming, minor method ordering improvement - [`91e706d`](https://github.com/jellyfin/jellyfin/commit/91e706d3873440a28f107da04143a374d4277b9a) Implement sort test for ProviderManager.GetMetadataProviders - [`e7df72d`](https://github.com/jellyfin/jellyfin/commit/e7df72de497f25deb7f77bf9de39aeaba1159d11) Improve metadata provider sorting - [`d5e2c2f`](https://github.com/jellyfin/jellyfin/commit/d5e2c2fb5e8a1328a2e938a7100a1ceb29b28fa7) Implement CanRefreshMetadata tests for GetMetadataProviders ### 📊 Changes **8 files changed** (+776 additions, -225 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/BaseItemManager/BaseItemManager.cs` (+6 -8) 📝 `MediaBrowser.Controller/BaseItemManager/IBaseItemManager.cs` (+4 -4) 📝 `MediaBrowser.Controller/Providers/IMetadataService.cs` (+5 -0) 📝 `MediaBrowser.Controller/Providers/IProviderManager.cs` (+18 -0) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+2 -2) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+115 -191) 📝 `tests/Jellyfin.Controller.Tests/BaseItemManagerTests.cs` (+12 -20) ➕ `tests/Jellyfin.Providers.Tests/Manager/ProviderManagerTests.cs` (+614 -0) </details> ### 📄 Description A bunch of incremental improvements to ProviderManager.cs and related files, primarily focusing on `RefreshSingleItem`, `GetImageProviders`, and `GetMetadataProviders`. **Changes** - Pulled a couple public methods up to the interface, resolved `#nullable disable`, general minor cleanup - Stored library type options and fetcher order logic up front instead of rechecking multiple times for each provider - Merged and simplified similar/duplicated code for image and metadata sorting - Added unit tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:34:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?