starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6915] [MERGED] Subtitle filename parsing fix #11192

New Issue
Closed
opened 2026-02-07 06:34:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:34:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6915
Author: @1337joe
Created: 11/27/2021
Status: ✅ Merged
Merged: 11/28/2021
Merged by: @crobibero

Base: master ← Head: subtitle-parsing-fix

📝 Commits (2)

  • 4a20ae6 Allow default/forced tag without setting language
  • 1df5b50 Address suppressed warnings

📊 Changes

2 files changed (+77 additions, -8 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs (+46 -8)
📝 tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs (+31 -0)

📄 Description

Changes

  • Add handling for default/forced/foreign tag when no language is set (with tests)
  • Address suppressed warnings on SubtitleResolver

Issues
Fixes #6911

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6915 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 11/27/2021 **Status:** ✅ Merged **Merged:** 11/28/2021 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `subtitle-parsing-fix` --- ### 📝 Commits (2) - [`4a20ae6`](https://github.com/jellyfin/jellyfin/commit/4a20ae6cb414e5ec06ea17dca2a1b44db4d187af) Allow default/forced tag without setting language - [`1df5b50`](https://github.com/jellyfin/jellyfin/commit/1df5b5034b944360a82957acd22a3b1dae040113) Address suppressed warnings ### 📊 Changes **2 files changed** (+77 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs` (+46 -8) 📝 `tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs` (+31 -0) </details> ### 📄 Description **Changes** - Add handling for default/forced/foreign tag when no language is set (with tests) - Address suppressed warnings on `SubtitleResolver` **Issues** Fixes #6911 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:34:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?