starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6898] [MERGED] Add support for external audio files #11191

New Issue
Closed
opened 2026-02-07 06:34:00 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:34:00 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6898
Author: @jonas-resch
Created: 11/23/2021
Status: ✅ Merged
Merged: 12/11/2021
Merged by: @crobibero

Base: master ← Head: support-external-audio-files

📝 Commits (10+)

  • 9978164 Add support for external audio files
  • c1a8385 Shorten calculation of audio startIndex in MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
  • 5e91f50 Update CONTRIBUTORS.md
  • a68e585 Implement code feedback
  • f1862f9 Add ConfigureAwait false to MediaBrowser.Providers/MediaInfo/AudioResolver.cs
  • a3c5afa Add ConfigureAwait false MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
  • 9433072 Only search in video folder for external audio files
  • 61b191d Fix indentation in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
  • d016d48 Change return type from Task<List> to Task<IAsyncEnumerable> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs
  • bbf1399 Check language for null or empty instead of only null in MediaBrowser.Providers/MediaInfo/AudioResolver.cs

📊 Changes

6 files changed (+255 additions, -10 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.Controller/Entities/Video.cs (+7 -0)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+23 -4)
➕ MediaBrowser.Providers/MediaInfo/AudioResolver.cs (+176 -0)
📝 MediaBrowser.Providers/MediaInfo/FFProbeProvider.cs (+17 -5)
📝 MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs (+31 -1)

📄 Description

Changes
Adds support for external audio files. Works similar to external subtitles.
Once this feature is released the docs need to be updated (https://jellyfin.org/docs/general/server/media/movies.html or new subentry like Subtitles?)

Issues
#143 / https://features.jellyfin.org/posts/177/support-external-audio-tracks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6898 **Author:** [@jonas-resch](https://github.com/jonas-resch) **Created:** 11/23/2021 **Status:** ✅ Merged **Merged:** 12/11/2021 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `support-external-audio-files` --- ### 📝 Commits (10+) - [`9978164`](https://github.com/jellyfin/jellyfin/commit/997816443862a8db68f314a6d23ef076c9661c01) Add support for external audio files - [`c1a8385`](https://github.com/jellyfin/jellyfin/commit/c1a8385c9ceb70d9ad4301e7032e1719fe1bdc23) Shorten calculation of audio startIndex in MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs - [`5e91f50`](https://github.com/jellyfin/jellyfin/commit/5e91f50c437adcf28cc80eba970c87fddf4f0c9f) Update CONTRIBUTORS.md - [`a68e585`](https://github.com/jellyfin/jellyfin/commit/a68e58556c49ee9bc1c27fac696ffc9170c95e84) Implement code feedback - [`f1862f9`](https://github.com/jellyfin/jellyfin/commit/f1862f9b1a9d6daa0315308671cfb6d0fdd6a989) Add ConfigureAwait false to MediaBrowser.Providers/MediaInfo/AudioResolver.cs - [`a3c5afa`](https://github.com/jellyfin/jellyfin/commit/a3c5afa443dca5cfd90ff1a33b7af9dbfe751ff4) Add ConfigureAwait false MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs - [`9433072`](https://github.com/jellyfin/jellyfin/commit/9433072f90593a43d2faa4eb645eb521a257205c) Only search in video folder for external audio files - [`61b191d`](https://github.com/jellyfin/jellyfin/commit/61b191d34556a0dad260344e83b9f40ac12f28ce) Fix indentation in MediaBrowser.Providers/MediaInfo/AudioResolver.cs - [`d016d48`](https://github.com/jellyfin/jellyfin/commit/d016d483ae5ab79f6f1171ce7f6ca99b8cd91cf0) Change return type from Task<List<MediaStream>> to Task<IAsyncEnumerable<MediaStream>> in MediaBrowser.Providers/MediaInfo/AudioResolver.cs - [`bbf1399`](https://github.com/jellyfin/jellyfin/commit/bbf1399826f92241a653adbb808a4cc7ea6a5542) Check language for null or empty instead of only null in MediaBrowser.Providers/MediaInfo/AudioResolver.cs ### 📊 Changes **6 files changed** (+255 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.Controller/Entities/Video.cs` (+7 -0) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+23 -4) ➕ `MediaBrowser.Providers/MediaInfo/AudioResolver.cs` (+176 -0) 📝 `MediaBrowser.Providers/MediaInfo/FFProbeProvider.cs` (+17 -5) 📝 `MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs` (+31 -1) </details> ### 📄 Description **Changes** Adds support for external audio files. Works similar to external subtitles. Once this feature is released the docs need to be updated ([https://jellyfin.org/docs/general/server/media/movies.html](https://jellyfin.org/docs/general/server/media/movies.html) or new subentry like Subtitles?) **Issues** [#143](https://github.com/jellyfin/jellyfin/issues/143) / [https://features.jellyfin.org/posts/177/support-external-audio-tracks](https://features.jellyfin.org/posts/177/support-external-audio-tracks) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:34:00 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?