starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6860] [MERGED] Read past empty elements #11167

New Issue
Closed
opened 2026-02-07 06:33:39 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:33:39 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6860
Author: @cvium
Created: 11/17/2021
Status: ✅ Merged
Merged: 11/17/2021
Merged by: @crobibero

Base: master ← Head: fix_xml_endless_loops

📝 Commits (1)

📊 Changes

2 files changed (+30 additions, -6 deletions)

View changed files

📝 MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs (+23 -5)
📝 MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs (+7 -1)

📄 Description

Changes
ReadSubtree does not advance the reader, so when the element is empty it will keep reading the empty element forever. I have added some extra IsEmptyElement checks

Issues
Fixes https://github.com/jellyfin/jellyfin/issues/6858

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6860 **Author:** [@cvium](https://github.com/cvium) **Created:** 11/17/2021 **Status:** ✅ Merged **Merged:** 11/17/2021 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix_xml_endless_loops` --- ### 📝 Commits (1) - [`61b75c8`](https://github.com/jellyfin/jellyfin/commit/61b75c82ce6b5b1bb709fb37fc66e7e26750559f) Read past empty elements ### 📊 Changes **2 files changed** (+30 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs` (+23 -5) 📝 `MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs` (+7 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** ReadSubtree does not advance the reader, so when the element is empty it will keep reading the empty element forever. I have added some extra IsEmptyElement checks **Issues** Fixes https://github.com/jellyfin/jellyfin/issues/6858 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:33:39 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?