starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6820] [CLOSED] Add/expose image settings for video extras #11151

New Issue
Closed
opened 2026-02-07 06:33:21 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:33:21 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6820
Author: @1337joe
Created: 11/11/2021
Status: ❌ Closed

Base: master ← Head: expose-extras-options

📝 Commits (2)

  • 3046128 Add/expose settings for video extras
  • 0a00dd5 Revert trailer fallback to video

📊 Changes

3 files changed (+24 additions, -6 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+15 -2)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+3 -3)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+6 -1)

📄 Description

Old state: If no library TypeOptions are found for a type a default option is used that enables all image providers. This allows the usage of a dummy object for populating the options panel, but results in image providers that the user disabled for Movie being run on any extras, trailers, or secondary video files also in the directory with the primary movie file.

Changes

  • Fall back to Owner on missing Parent when searching up the tree for the library root to allow options to be found for owned items.
  • Fall back to Video when type Trailer not found in library options.
  • Add check to ensure owned videos know their owner on metadata refresh (videos created from the Video.LocalAlternateVersions list didn't know their owner).
  • Add Video library options to allow the user to modify image collection settings for video extras.

"Extras" would be a better name for the library options, but options are looked up by type name, and in this case the problematic files were of type types Trailer or Video.

Issues
Possibly related to #2355

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6820 **Author:** [@1337joe](https://github.com/1337joe) **Created:** 11/11/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `expose-extras-options` --- ### 📝 Commits (2) - [`3046128`](https://github.com/jellyfin/jellyfin/commit/30461280d1447f21a6f42cb358aa8401282dd766) Add/expose settings for video extras - [`0a00dd5`](https://github.com/jellyfin/jellyfin/commit/0a00dd59826019d71354bf52437b24bbb6f3955e) Revert trailer fallback to video ### 📊 Changes **3 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+15 -2) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+3 -3) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+6 -1) </details> ### 📄 Description Old state: If no library `TypeOptions` are found for a type a default option is used that enables all image providers. This allows the usage of a dummy object for populating the options panel, but results in image providers that the user disabled for `Movie` being run on any extras, trailers, or secondary video files also in the directory with the primary movie file. **Changes** - Fall back to `Owner` on missing `Parent` when searching up the tree for the library root to allow options to be found for owned items. - Fall back to `Video` when type `Trailer` not found in library options. - Add check to ensure owned videos know their owner on metadata refresh (videos created from the `Video.LocalAlternateVersions` list didn't know their owner). - Add `Video` library options to allow the user to modify image collection settings for video extras. "Extras" would be a better name for the library options, but options are looked up by type name, and in this case the problematic files were of type types `Trailer` or `Video`. **Issues** Possibly related to #2355 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:33:21 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?