starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6667] [MERGED] Fix the last few warnings #11079

New Issue
Closed
opened 2026-02-07 06:32:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:32:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6667
Author: @Bond-009
Created: 10/6/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @Bond-009

Base: master ← Head: warn53

📝 Commits (2)

  • 03f933a Fix the last few warnings
  • f7ae3c6 Set AnalysisMode to AllEnabledByDefault

📊 Changes

31 files changed (+353 additions, -307 deletions)

View changed files

📝 Emby.Dlna/Emby.Dlna.csproj (+0 -1)
📝 Emby.Drawing/Emby.Drawing.csproj (+0 -1)
📝 Emby.Naming/Emby.Naming.csproj (+0 -1)
📝 Emby.Server.Implementations/ApplicationHost.cs (+12 -26)
📝 Emby.Server.Implementations/Data/BaseSqliteRepository.cs (+1 -1)
📝 Emby.Server.Implementations/Emby.Server.Implementations.csproj (+0 -5)
📝 Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs (+2 -2)
➕ Emby.Server.Implementations/Images/BaseFolderImageProvider.cs (+67 -0)
📝 Emby.Server.Implementations/Images/FolderImageProvider.cs (+0 -69)
📝 Emby.Server.Implementations/Images/GenreImageProvider.cs (+0 -41)
➕ Emby.Server.Implementations/Images/MusicAlbumImageProvider.cs (+19 -0)
➕ Emby.Server.Implementations/Images/MusicGenreImageProvider.cs (+59 -0)
➕ Emby.Server.Implementations/Images/PhotoAlbumImageProvider.cs (+19 -0)
📝 Emby.Server.Implementations/Library/Resolvers/FolderResolver.cs (+1 -21)
➕ Emby.Server.Implementations/Library/Resolvers/GenericFolderResolver.cs (+27 -0)
📝 Emby.Server.Implementations/Library/Resolvers/Movies/BoxSetResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/PhotoAlbumResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/SpecialFolderResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Library/Resolvers/TV/SeasonResolver.cs (+1 -1)

...and 11 more files

📄 Description

Enables TreatWarningsAsErrors for all projects

Should fix #2149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6667 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 10/6/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `warn53` --- ### 📝 Commits (2) - [`03f933a`](https://github.com/jellyfin/jellyfin/commit/03f933aaa07113b0ae6971921249691c8455d5ba) Fix the last few warnings - [`f7ae3c6`](https://github.com/jellyfin/jellyfin/commit/f7ae3c6a858ccc8489e222492351461f1134a058) Set AnalysisMode to AllEnabledByDefault ### 📊 Changes **31 files changed** (+353 additions, -307 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Emby.Dlna.csproj` (+0 -1) 📝 `Emby.Drawing/Emby.Drawing.csproj` (+0 -1) 📝 `Emby.Naming/Emby.Naming.csproj` (+0 -1) 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+12 -26) 📝 `Emby.Server.Implementations/Data/BaseSqliteRepository.cs` (+1 -1) 📝 `Emby.Server.Implementations/Emby.Server.Implementations.csproj` (+0 -5) 📝 `Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs` (+2 -2) ➕ `Emby.Server.Implementations/Images/BaseFolderImageProvider.cs` (+67 -0) 📝 `Emby.Server.Implementations/Images/FolderImageProvider.cs` (+0 -69) 📝 `Emby.Server.Implementations/Images/GenreImageProvider.cs` (+0 -41) ➕ `Emby.Server.Implementations/Images/MusicAlbumImageProvider.cs` (+19 -0) ➕ `Emby.Server.Implementations/Images/MusicGenreImageProvider.cs` (+59 -0) ➕ `Emby.Server.Implementations/Images/PhotoAlbumImageProvider.cs` (+19 -0) 📝 `Emby.Server.Implementations/Library/Resolvers/FolderResolver.cs` (+1 -21) ➕ `Emby.Server.Implementations/Library/Resolvers/GenericFolderResolver.cs` (+27 -0) 📝 `Emby.Server.Implementations/Library/Resolvers/Movies/BoxSetResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/PhotoAlbumResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/SpecialFolderResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Library/Resolvers/TV/SeasonResolver.cs` (+1 -1) _...and 11 more files_ </details> ### 📄 Description Enables TreatWarningsAsErrors for all projects Should fix #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:32:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11079
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?