mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #6639] [MERGED] Add mp4 track title fallback #11062
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/6639
Author: @1337joe
Created: 9/30/2021
Status: ✅ Merged
Merged: 10/1/2021
Merged by: @cvium
Base:
master← Head:mp4-track-title-fallback📝 Commits (1)
ce0457fAdd mp4 track title fallback (#6638)📊 Changes
1 file changed (+20 additions, -0 deletions)
View changed files
📝
MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs(+20 -0)📄 Description
Changes
In the case that a track title isn't set for audio or subtitle tracks this change checks for a "handler_name" field to use as a title.
Explanation
Handbrake-produced mp4 files don't have a title set on audio or subtitle tracks, but looking at the handbrake code there's a check for mp4 file type that adds the title to the "handler_name" field: Audio Subtitle
Additionally, there's a note in the ffmpeg encoder referencing the use of "handler_name" for track description: movenc.c
As this seems to be a common/accepted use of the field, Jellyfin should read it if there is no track title set.
Issues
Fixes #6638
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.