starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6617] [CLOSED] FIX: cannot compare bitstream of different video codec #11060

New Issue
Closed
opened 2026-02-07 06:31:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:31:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6617
Author: @koying
Created: 9/26/2021
Status: ❌ Closed

Base: master ← Head: fixbistreamdownscale

📝 Commits (1)

  • 120ee18 FIX: cannot compare bitstream of different video codec

📊 Changes

1 file changed (+8 additions, -30 deletions)

View changed files

📝 Jellyfin.Api/Helpers/StreamingHelpers.cs (+8 -30)

📄 Description

Changes

It doesn't really make sense to compare bitstream rate of 2 different codec.
Not downscaling because, e.g., a hevc 9Mb/s is lower than a h264 10Mb/s is comparing pears and apples.

Partial revert of https://github.com/jellyfin/jellyfin/pull/4432

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6617 **Author:** [@koying](https://github.com/koying) **Created:** 9/26/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fixbistreamdownscale` --- ### 📝 Commits (1) - [`120ee18`](https://github.com/jellyfin/jellyfin/commit/120ee1875c0c8ef68c7e3627d663975c443ea250) FIX: cannot compare bitstream of different video codec ### 📊 Changes **1 file changed** (+8 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Helpers/StreamingHelpers.cs` (+8 -30) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> It doesn't really make sense to compare bitstream rate of 2 different codec. Not downscaling because, e.g., a hevc 9Mb/s is lower than a h264 10Mb/s is comparing pears and apples. Partial revert of https://github.com/jellyfin/jellyfin/pull/4432 **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:31:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?