starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6616] [MERGED] Remove all instances of en-US culture #11055

New Issue
Closed
opened 2026-02-07 06:31:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:31:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6616
Author: @crobibero
Created: 9/26/2021
Status: ✅ Merged
Merged: 9/26/2021
Merged by: @Bond-009

Base: master ← Head: culture-info

📝 Commits (1)

  • 9234e5b Remove all instances of en-US culture

📊 Changes

23 files changed (+116 additions, -152 deletions)

View changed files

📝 Emby.Dlna/Didl/DidlBuilder.cs (+13 -15)
📝 Emby.Dlna/Eventing/DlnaEventManager.cs (+3 -5)
📝 Emby.Dlna/PlayTo/Device.cs (+5 -7)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+3 -5)
📝 Emby.Dlna/PlayTo/SsdpHttpClient.cs (+3 -5)
📝 Emby.Dlna/Server/DescriptionXmlBuilder.cs (+2 -3)
📝 Emby.Server.Implementations/MediaEncoder/EncodingManager.cs (+1 -2)
📝 Jellyfin.Api/Controllers/ImageController.cs (+1 -1)
📝 Jellyfin.Api/Controllers/SubtitleController.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/Year.cs (+1 -3)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+20 -22)
📝 MediaBrowser.Controller/MediaEncoding/JobLogger.cs (+5 -6)
📝 MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs (+1 -3)
📝 MediaBrowser.LocalMetadata/Parsers/BaseItemXmlParser.cs (+3 -5)
📝 MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs (+5 -7)
📝 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs (+3 -8)
📝 MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs (+13 -14)
📝 MediaBrowser.Model/Globalization/ILocalizationManager.cs (+2 -2)
📝 MediaBrowser.Providers/Manager/ImageSaver.cs (+8 -10)
📝 MediaBrowser.Providers/Plugins/Omdb/OmdbProvider.cs (+6 -7)

...and 3 more files

📄 Description

The only area that I know differs between Invariant culture an en-US is default Date formatting, and currency sign.

Regex used: CultureInfo(?!\.InvariantCulture)

Remaining CultureInfos:
82cb685178/MediaBrowser.Model/Entities/MediaStream.cs (L143-L146)
82cb685178/MediaBrowser.Model/Entities/MediaStream.cs (L237-L240)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6616 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 9/26/2021 **Status:** ✅ Merged **Merged:** 9/26/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `culture-info` --- ### 📝 Commits (1) - [`9234e5b`](https://github.com/jellyfin/jellyfin/commit/9234e5bf80194e45acac25c60cb76f401bffaf96) Remove all instances of en-US culture ### 📊 Changes **23 files changed** (+116 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+13 -15) 📝 `Emby.Dlna/Eventing/DlnaEventManager.cs` (+3 -5) 📝 `Emby.Dlna/PlayTo/Device.cs` (+5 -7) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+3 -5) 📝 `Emby.Dlna/PlayTo/SsdpHttpClient.cs` (+3 -5) 📝 `Emby.Dlna/Server/DescriptionXmlBuilder.cs` (+2 -3) 📝 `Emby.Server.Implementations/MediaEncoder/EncodingManager.cs` (+1 -2) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/SubtitleController.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/Year.cs` (+1 -3) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+20 -22) 📝 `MediaBrowser.Controller/MediaEncoding/JobLogger.cs` (+5 -6) 📝 `MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs` (+1 -3) 📝 `MediaBrowser.LocalMetadata/Parsers/BaseItemXmlParser.cs` (+3 -5) 📝 `MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs` (+5 -7) 📝 `MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs` (+3 -8) 📝 `MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs` (+13 -14) 📝 `MediaBrowser.Model/Globalization/ILocalizationManager.cs` (+2 -2) 📝 `MediaBrowser.Providers/Manager/ImageSaver.cs` (+8 -10) 📝 `MediaBrowser.Providers/Plugins/Omdb/OmdbProvider.cs` (+6 -7) _...and 3 more files_ </details> ### 📄 Description The only area that I know differs between Invariant culture an en-US is default Date formatting, and currency sign. Regex used: `CultureInfo(?!\.InvariantCulture)` Remaining CultureInfos: https://github.com/jellyfin/jellyfin/blob/82cb6851786d4fb24952d77d869f9e9c005a960a/MediaBrowser.Model/Entities/MediaStream.cs#L143-L146 https://github.com/jellyfin/jellyfin/blob/82cb6851786d4fb24952d77d869f9e9c005a960a/MediaBrowser.Model/Entities/MediaStream.cs#L237-L240 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:31:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11055
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?