starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6531] [MERGED] Fix images "not loading" after manual identification #11014

New Issue
Closed
opened 2026-02-07 06:30:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:30:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6531
Author: @GodTamIt
Created: 9/9/2021
Status: ✅ Merged
Merged: 9/10/2021
Merged by: @Bond-009

Base: master ← Head: img-lang

📝 Commits (1)

  • b0cd1f5 Fix images "not loading" after manual identification

📊 Changes

9 files changed (+35 additions, -30 deletions)

View changed files

📝 MediaBrowser.Model/Extensions/EnumerableExtensions.cs (+12 -4)
📝 MediaBrowser.Providers/Manager/ItemImageProvider.cs (+2 -2)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+15 -14)
📝 MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetImageProvider.cs (+1 -1)
📝 MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieImageProvider.cs (+1 -2)
📝 MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonImageProvider.cs (+1 -2)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeImageProvider.cs (+1 -2)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonImageProvider.cs (+1 -1)
📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesImageProvider.cs (+1 -2)

📄 Description

Changes

This change fixes a bug where images (usually of type Primary) seem to "not load" after the user custom identifies and matches the metadata with a particular source. This is due to the fact that search results shown on the UI will show primary covers from another language if those are the only covers available (#6467 shows that it is probably common in anime). However, in the previous internal logic, the image filtering does not allow for images from all languages, leading to a confusing mismatch between UI/UX and internal metadata tagging logic.

The fix enables images from all languages to be included during internal image fetching but adds logic to order results by the preferred languages so that the preferred language settings are still honored. If there are images available in the preferred language, they will be ordered before other results.

Issues

Fixes #3676
Fixes #6467

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6531 **Author:** [@GodTamIt](https://github.com/GodTamIt) **Created:** 9/9/2021 **Status:** ✅ Merged **Merged:** 9/10/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `img-lang` --- ### 📝 Commits (1) - [`b0cd1f5`](https://github.com/jellyfin/jellyfin/commit/b0cd1f5e39a74c99e2c8ce015cc5d52b65dd4161) Fix images "not loading" after manual identification ### 📊 Changes **9 files changed** (+35 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Model/Extensions/EnumerableExtensions.cs` (+12 -4) 📝 `MediaBrowser.Providers/Manager/ItemImageProvider.cs` (+2 -2) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+15 -14) 📝 `MediaBrowser.Providers/Plugins/Tmdb/BoxSets/TmdbBoxSetImageProvider.cs` (+1 -1) 📝 `MediaBrowser.Providers/Plugins/Tmdb/Movies/TmdbMovieImageProvider.cs` (+1 -2) 📝 `MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonImageProvider.cs` (+1 -2) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeImageProvider.cs` (+1 -2) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonImageProvider.cs` (+1 -1) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesImageProvider.cs` (+1 -2) </details> ### 📄 Description **Changes** This change fixes a bug where images (usually of type `Primary`) seem to "not load" after the user custom identifies and matches the metadata with a particular source. This is due to the fact that search results shown on the UI will show primary covers from another language if those are the only covers available (#6467 shows that it is probably common in anime). However, in the previous internal logic, the image filtering does not allow for images from all languages, leading to a confusing mismatch between UI/UX and internal metadata tagging logic. The fix enables images from all languages to be included during internal image fetching but adds logic to order results by the preferred languages so that the preferred language settings are still honored. If there are images available in the preferred language, they will be ordered before other results. **Issues** Fixes #3676 Fixes #6467 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:30:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11014
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?