[PR #6495] [MERGED] Allow zero activity log retention days #10988

Closed
opened 2026-02-07 06:30:25 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6495
Author: @qsniyg
Created: 9/2/2021
Status: Merged
Merged: 9/2/2021
Merged by: @Bond-009

Base: masterHead: zero-activity-days


📝 Commits (1)

  • 2cf08dc Allow zero activity log retention days

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Emby.Server.Implementations/ScheduledTasks/Tasks/CleanActivityLogTask.cs (+1 -1)

📄 Description

Changes
The error message states that "Activity Log Retention days must be at least 0", but it fails with a value of zero, despite the message. This PR allows a value of 0.

A value of 0 is useful because it allows clearing the entire activity log through the "Clean Activity Log" task.

Issues
This is somewhat related to https://features.jellyfin.org/posts/1161/disable-or-anonymize-activity-logs


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6495 **Author:** [@qsniyg](https://github.com/qsniyg) **Created:** 9/2/2021 **Status:** ✅ Merged **Merged:** 9/2/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `zero-activity-days` --- ### 📝 Commits (1) - [`2cf08dc`](https://github.com/jellyfin/jellyfin/commit/2cf08dcd34db4d749a93de29e3ba13c633938e0c) Allow zero activity log retention days ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/CleanActivityLogTask.cs` (+1 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** The error message states that "Activity Log Retention days must be at least 0", but it fails with a value of zero, despite the message. This PR allows a value of 0. A value of 0 is useful because it allows clearing the entire activity log through the "Clean Activity Log" task. **Issues** This is somewhat related to https://features.jellyfin.org/posts/1161/disable-or-anonymize-activity-logs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:30:25 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10988