mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #6466] [CLOSED] Users/rmcn96/fix readonly image #10978
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/6466
Author: @AgentScrubbles
Created: 8/25/2021
Status: ❌ Closed
Base:
master← Head:users/rmcn96/fix-readonly-image📝 Commits (10+)
aff717aOpening up debugging, catching exception8edff53Trying to get cicd up95b1514Trying to get cicd up1806197Trying to get cicd up856a38aTrying to enable debugging in the dockerfile690cb29Fixing buildac3cbf5Do not throw if file is not allowed to be deleted76fd463Cleaning up the methodcff3c14Adding catch clause for read onlye5df947Cleanup📊 Changes
2 files changed (+8 additions, -0 deletions)
View changed files
📝
MediaBrowser.Providers/Manager/ImageSaver.cs(+4 -0)📝
MediaBrowser.Providers/Manager/ItemImageProvider.cs(+4 -0)📄 Description
Changes
To reproduce: Media is stored on a read-only medium, such as a readonly mount. Have a piece of media that has a cover art automatically read in by the media scanner. If you try to replace that cover art, the API would return a 500 error due to the underlying system being read only.
The issue is resolved by handling the read-only IO Exception in the same manner it handles files that are not found. It now ignores the error (because it is not allowed to delete the file), and continues with the metadata changes. In the internal DB it recognizes that the art has been changed, while the original file is untouched.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.