starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #6284] [CLOSED] Restore #5717 on 10.7.x #10891

New Issue
Closed
opened 2026-02-07 06:28:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:28:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6284
Author: @sbstp
Created: 7/11/2021
Status: ❌ Closed

Base: release-10.7.z ← Head: backport-5717

📝 Commits (2)

📊 Changes

2 files changed (+3 additions, -4 deletions)

View changed files

📝 Jellyfin.Data/Entities/CustomItemDisplayPreferences.cs (+2 -3)
📝 Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs (+1 -1)

📄 Description

I'm running into this bug on 10.7.6, it's been fixed in master only so I want to backport it to the 10.7.z branch.

Changes
Backport #5717 on 10.7.z branch.

Issue
Stack trace with issue:

Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling.
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator )
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext()
Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling.
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator )
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext()
Jul 10 22:16:48 trinity docker[8567]: [02:16:48] [ERR] [39] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request. URL GET /DisplayPreferences/usersettings.
Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling.
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal)
Jul 10 22:16:48 trinity docker[8567]:    at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator )
Jul 10 22:16:48 trinity docker[8567]:    at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext()
Jul 10 22:16:48 trinity docker[8567]:    at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
Jul 10 22:16:48 trinity docker[8567]:    at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector)
Jul 10 22:16:48 trinity docker[8567]:    at Jellyfin.Server.Implementations.Users.DisplayPreferencesManager.ListCustomItemDisplayPreferences(Guid userId, Guid itemId, String client)
Jul 10 22:16:48 trinity docker[8567]:    at Jellyfin.Api.Controllers.DisplayPreferencesController.GetDisplayPreferences(String displayPreferencesId, Guid userId, String client)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6284 **Author:** [@sbstp](https://github.com/sbstp) **Created:** 7/11/2021 **Status:** ❌ Closed **Base:** `release-10.7.z` ← **Head:** `backport-5717` --- ### 📝 Commits (2) - [`f4c0f0b`](https://github.com/jellyfin/jellyfin/commit/f4c0f0b30adfd94475c695a0e362c49372fa3352) make custompref value nullable - [`b1d37ab`](https://github.com/jellyfin/jellyfin/commit/b1d37ab1bbd7815d9db5073e4d925173b0725acc) fix build...somehow ### 📊 Changes **2 files changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Data/Entities/CustomItemDisplayPreferences.cs` (+2 -3) 📝 `Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs` (+1 -1) </details> ### 📄 Description I'm running into this bug on 10.7.6, it's been fixed in master only so I want to backport it to the 10.7.z branch. **Changes** Backport #5717 on 10.7.z branch. **Issue** Stack trace with issue: ``` Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling. Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator ) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext() Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling. Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator ) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext() Jul 10 22:16:48 trinity docker[8567]: [02:16:48] [ERR] [39] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request. URL GET /DisplayPreferences/usersettings. Jul 10 22:16:48 trinity docker[8567]: System.InvalidOperationException: The data is NULL at ordinal 5. This method can't be called on NULL values. Check using IsDBNull before calling. Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteValueReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.Data.Sqlite.SqliteDataReader.GetString(Int32 ordinal) Jul 10 22:16:48 trinity docker[8567]: at lambda_method694(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator ) Jul 10 22:16:48 trinity docker[8567]: at Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable`1.Enumerator.MoveNext() Jul 10 22:16:48 trinity docker[8567]: at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer) Jul 10 22:16:48 trinity docker[8567]: at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector) Jul 10 22:16:48 trinity docker[8567]: at Jellyfin.Server.Implementations.Users.DisplayPreferencesManager.ListCustomItemDisplayPreferences(Guid userId, Guid itemId, String client) Jul 10 22:16:48 trinity docker[8567]: at Jellyfin.Api.Controllers.DisplayPreferencesController.GetDisplayPreferences(String displayPreferencesId, Guid userId, String client) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:28:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10891
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?