starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6200] [MERGED] Refactor Quick Connect #10863

New Issue
Closed
opened 2026-02-07 06:28:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:28:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6200
Author: @nielsvanvelzen
Created: 6/18/2021
Status: ✅ Merged
Merged: 6/22/2021
Merged by: @cvium

Base: master ← Head: fix-quickconnect

📝 Commits (1)

📊 Changes

5 files changed (+94 additions, -258 deletions)

View changed files

📝 Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs (+51 -111)
📝 Jellyfin.Api/Controllers/QuickConnectController.cs (+21 -58)
📝 MediaBrowser.Controller/QuickConnect/IQuickConnect.cs (+2 -54)
📝 MediaBrowser.Model/QuickConnect/QuickConnectResult.cs (+20 -12)
➖ MediaBrowser.Model/QuickConnect/QuickConnectState.cs (+0 -23)

📄 Description

Changes

  • Enable nullable in Quick Connect code
  • Some miscellaneous refactoring in Quick Connect code ,mostly based on Rider hints
  • Increased Quick Connect timeout to 10 minutes (was 5)
  • Move from 3-state (sort-of-on/on/off) to 2-state (on/off)
  • Remove "activation" shit, when it's on in the server you can request codes. simple as that.
  • Add proper HTTP responses when disabled (instead of HTTP 500)
  • Change functions not used from interface to private / remove from interface
  • Change token type to UUID
  • Fix nullability in
  • Remove delete functions (unused)
  • Read state directly from system config, this fixes updating the config not enabling quick connect

API Changes

  • Removed "status" endpoint, replaced with "enabled" endpoint
    • Return type changed to boolean
  • Add Unauthorized responses when Quick Connect is disabled
  • Remove "activate" endpoint
  • Remove "available" endpoint
    • Use system configuration api instead
  • Remove "Deauthorize" endpoint

Related pull requests

jellyfin/jellyfin-web#2747
jellyfin/jellyfin-web#2748
jellyfin/jellyfin-web#2749

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6200 **Author:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Created:** 6/18/2021 **Status:** ✅ Merged **Merged:** 6/22/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `fix-quickconnect` --- ### 📝 Commits (1) - [`7d46ca9`](https://github.com/jellyfin/jellyfin/commit/7d46ca931768b02806c72a5c1103e315b10db719) Refactor Quick Connect ### 📊 Changes **5 files changed** (+94 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs` (+51 -111) 📝 `Jellyfin.Api/Controllers/QuickConnectController.cs` (+21 -58) 📝 `MediaBrowser.Controller/QuickConnect/IQuickConnect.cs` (+2 -54) 📝 `MediaBrowser.Model/QuickConnect/QuickConnectResult.cs` (+20 -12) ➖ `MediaBrowser.Model/QuickConnect/QuickConnectState.cs` (+0 -23) </details> ### 📄 Description **Changes** - Enable nullable in Quick Connect code - Some miscellaneous refactoring in Quick Connect code ,mostly based on Rider hints - Increased Quick Connect timeout to 10 minutes (was 5) - Move from 3-state (sort-of-on/on/off) to 2-state (on/off) - Remove "activation" shit, when it's on in the server you can request codes. simple as that. - Add proper HTTP responses when disabled (instead of HTTP 500) - Change functions not used from interface to private / remove from interface - Change token type to UUID - Fix nullability in - Remove delete functions (unused) - Read state directly from system config, this fixes updating the config not enabling quick connect **API Changes** - Removed "status" endpoint, replaced with "enabled" endpoint - Return type changed to boolean - Add Unauthorized responses when Quick Connect is disabled - Remove "activate" endpoint - Remove "available" endpoint - Use system configuration api instead - Remove "Deauthorize" endpoint **Related pull requests** jellyfin/jellyfin-web#2747 jellyfin/jellyfin-web#2748 jellyfin/jellyfin-web#2749 **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:28:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?