starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6176] [MERGED] Require userId in getItems and getTrailers endpoints #10848

New Issue
Closed
opened 2026-02-07 06:27:49 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:27:49 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6176
Author: @nielsvanvelzen
Created: 6/12/2021
Status: ✅ Merged
Merged: 6/13/2021
Merged by: @Bond-009

Base: master ← Head: userid-required

📝 Commits (1)

  • 226abde Change userId to required in operations that would otherwise throw exceptions

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 Jellyfin.Api/Controllers/ItemsController.cs (+3 -3)
📝 Jellyfin.Api/Controllers/TrailersController.cs (+1 -1)

📄 Description

Changes

The user is expected to be not-null meaning the userId parameter is required. I'm quite sure a lot of other endpoints require the userId too as they often fallback to Guid.Empty which might throw exceptions from somewhere deeper in the code (although not tested)

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6176 **Author:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Created:** 6/12/2021 **Status:** ✅ Merged **Merged:** 6/13/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `userid-required` --- ### 📝 Commits (1) - [`226abde`](https://github.com/jellyfin/jellyfin/commit/226abde3f72ccfc768766ce2ff295cb0972b6426) Change userId to required in operations that would otherwise throw exceptions ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/ItemsController.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/TrailersController.cs` (+1 -1) </details> ### 📄 Description **Changes** The user is expected to be not-null meaning the userId parameter is required. I'm quite sure a lot of other endpoints require the userId too as they often fallback to `Guid.Empty` which might throw exceptions from somewhere deeper in the code (although not tested) **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:27:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10848
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?