starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6139] [MERGED] Don't dispose managed CancellationTokenSource #10834

New Issue
Closed
opened 2026-02-07 06:27:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:27:33 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6139
Author: @crobibero
Created: 6/2/2021
Status: ✅ Merged
Merged: 6/4/2021
Merged by: @Bond-009

Base: master ← Head: cts

📝 Commits (4)

  • 3629682 Don't dispose CTS, add comments
  • b986ee1 Properly dispose of all TranscodingJobDto resources
  • 2f05c9a Remove whitespace
  • f44882e Flip inverted condition

📊 Changes

7 files changed (+36 additions, -4 deletions)

View changed files

📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+2 -1)
📝 Jellyfin.Api/Controllers/VideoHlsController.cs (+1 -0)
📝 Jellyfin.Api/Controllers/VideosController.cs (+1 -0)
📝 Jellyfin.Api/Helpers/AudioHelper.cs (+2 -0)
📝 Jellyfin.Api/Helpers/DynamicHlsHelper.cs (+1 -0)
📝 Jellyfin.Api/Helpers/TranscodingJobHelper.cs (+2 -2)
📝 Jellyfin.Api/Models/PlaybackDtos/TranscodingJobDto.cs (+27 -1)

📄 Description

Fixes an issue reported here.
Fixes https://github.com/jellyfin/jellyfin/issues/6141

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6139 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 6/2/2021 **Status:** ✅ Merged **Merged:** 6/4/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `cts` --- ### 📝 Commits (4) - [`3629682`](https://github.com/jellyfin/jellyfin/commit/36296825b025564800af319645a2fd08aeffe3db) Don't dispose CTS, add comments - [`b986ee1`](https://github.com/jellyfin/jellyfin/commit/b986ee17585a44cdb8ce72e41465106e5969df94) Properly dispose of all TranscodingJobDto resources - [`2f05c9a`](https://github.com/jellyfin/jellyfin/commit/2f05c9a4c767ee3af6dc6e429c9d0efbfdf99f40) Remove whitespace - [`f44882e`](https://github.com/jellyfin/jellyfin/commit/f44882ebfc633b4fecc06561c21c0f0bf683ecc1) Flip inverted condition ### 📊 Changes **7 files changed** (+36 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/VideoHlsController.cs` (+1 -0) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+1 -0) 📝 `Jellyfin.Api/Helpers/AudioHelper.cs` (+2 -0) 📝 `Jellyfin.Api/Helpers/DynamicHlsHelper.cs` (+1 -0) 📝 `Jellyfin.Api/Helpers/TranscodingJobHelper.cs` (+2 -2) 📝 `Jellyfin.Api/Models/PlaybackDtos/TranscodingJobDto.cs` (+27 -1) </details> ### 📄 Description Fixes an issue reported [here](https://github.com/jellyfin/jellyfin/pull/6013#issuecomment-847272144). Fixes https://github.com/jellyfin/jellyfin/issues/6141 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:27:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?