starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6131] [MERGED] Fix network flooding issue #10827

New Issue
Closed
opened 2026-02-07 06:27:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:27:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6131
Author: @BaronGreenback
Created: 5/30/2021
Status: ✅ Merged
Merged: 6/3/2021
Merged by: @joshuaboniface

Base: master ← Head: Fix_NetworkFlooding

📝 Commits (1)

  • 40a43f9 remove link between ssdp and upnp

📊 Changes

1 file changed (+0 additions, -9 deletions)

View changed files

📝 Emby.Server.Implementations/EntryPoints/ExternalPortForwarding.cs (+0 -9)

📄 Description

Remove link between DLNA and upnp.

UPnP does the port forwarding on the router by using SSDP broadcasts. DLNA does similar.

A link was placed between these to subsystems to speed up network device identification. This however, caused a loop whereby DLNA would pick up a device, and pass it to UPNP which would send out a notication, which DLNA would pick up and pass back to UPNP which would send out a notification. (Rinse and repeat) As each notification consists of 2-3 broadcasts, so the result is an exponential network flooding.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6131 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 5/30/2021 **Status:** ✅ Merged **Merged:** 6/3/2021 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `Fix_NetworkFlooding` --- ### 📝 Commits (1) - [`40a43f9`](https://github.com/jellyfin/jellyfin/commit/40a43f9485bef407dfdf78ac6dfabcac6d031349) remove link between ssdp and upnp ### 📊 Changes **1 file changed** (+0 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/EntryPoints/ExternalPortForwarding.cs` (+0 -9) </details> ### 📄 Description Remove link between DLNA and upnp. UPnP does the port forwarding on the router by using SSDP broadcasts. DLNA does similar. A link was placed between these to subsystems to speed up network device identification. This however, caused a loop whereby DLNA would pick up a device, and pass it to UPNP which would send out a notication, which DLNA would pick up and pass back to UPNP which would send out a notification. (Rinse and repeat) As each notification consists of 2-3 broadcasts, so the result is an exponential network flooding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:27:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10827
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?