[PR #6078] [MERGED] Remove warninigs from MediaBrowser.Controller (Part 3) #10816

New Issue

OVERLORD · 2026-02-07T06:27:12+03:00

OVERLORD commented

2026-02-07 06:27:12 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6078
Author: @crobibero
Created: 5/19/2021
Status: ✅ Merged
Merged: 6/6/2021
Merged by: @Bond-009

Base: master ← Head: warn-003

📝 Commits (7)

88e2ecc Remove warnings from MediaBrowser.Controller
4c4ba51 Apply suggestions from code review
4a2fcc1 Suggestion from review
d8510c1 Merge remote-tracking branch 'origin/warn-003' into warn-003
5746578 Merge remote-tracking branch 'upstream/master' into warn-003
5bc4c82 Fix do..while warning
8cb5f1a Revert culture comparison

📊 Changes

40 files changed (+183 additions, -136 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+5 -5)
📝 MediaBrowser.Controller/Channels/IDisableMediaSourceDisplay.cs (+7 -1)
📝 MediaBrowser.Controller/Channels/ISupportsMediaProbe.cs (+4 -1)
📝 MediaBrowser.Controller/Entities/AggregateFolder.cs (+3 -3)
📝 MediaBrowser.Controller/Entities/Audio/Audio.cs (+5 -4)
📝 MediaBrowser.Controller/Entities/Audio/MusicArtist.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+24 -18)
📝 MediaBrowser.Controller/Entities/CollectionFolder.cs (+3 -3)
📝 MediaBrowser.Controller/Entities/Folder.cs (+13 -14)
📝 MediaBrowser.Controller/Entities/Genre.cs (+5 -1)
📝 MediaBrowser.Controller/Entities/IHasScreenshots.cs (+3 -1)
📝 MediaBrowser.Controller/Entities/ISupportsBoxSetGrouping.cs (+2 -0)
📝 MediaBrowser.Controller/Entities/LinkedChildComparer.cs (+2 -1)
📝 MediaBrowser.Controller/Entities/TV/Episode.cs (+4 -3)
📝 MediaBrowser.Controller/Entities/TV/Season.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/UserRootFolder.cs (+2 -2)
📝 MediaBrowser.Controller/Entities/UserView.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/UserViewBuilder.cs (+10 -8)
📝 MediaBrowser.Controller/Entities/Video.cs (+2 -1)
📝 MediaBrowser.Controller/IO/FileData.cs (+1 -1)

...and 20 more files

📄 Description

Part of #2149

Warning codes remaining:

CA1711
CA2227
CA1002
CA1819
SA1201
SA1622
CA1051
SA1401
SA1306
CA1008
CA1721
SA1214
CA2211
SA1203
CA1044
SA1615
SA1611
SA1618
SA1627
CA1707
SA1614
CA1508
SA1617
CA1826
CA1835
CA1033
CA1724

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6078 **Author:** [@crobibero](https://github.com/crobibero) **Created:** 5/19/2021 **Status:** ✅ Merged **Merged:** 6/6/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `warn-003` --- ### 📝 Commits (7) - [`88e2ecc`](https://github.com/jellyfin/jellyfin/commit/88e2eccd2695cffa5386844a66a06fec7abc9e58) Remove warnings from MediaBrowser.Controller - [`4c4ba51`](https://github.com/jellyfin/jellyfin/commit/4c4ba51de1fd84029589a8ea733530bbba16706c) Apply suggestions from code review - [`4a2fcc1`](https://github.com/jellyfin/jellyfin/commit/4a2fcc121b3f226b71e3b9bd0829c5541e9efe53) Suggestion from review - [`d8510c1`](https://github.com/jellyfin/jellyfin/commit/d8510c189a957c5a55e06a47accfb49010686e1d) Merge remote-tracking branch 'origin/warn-003' into warn-003 - [`5746578`](https://github.com/jellyfin/jellyfin/commit/574657815aec202c6173b493eb126184e87e436a) Merge remote-tracking branch 'upstream/master' into warn-003 - [`5bc4c82`](https://github.com/jellyfin/jellyfin/commit/5bc4c82a35ecb9242256452670636878387a3d07) Fix do..while warning - [`8cb5f1a`](https://github.com/jellyfin/jellyfin/commit/8cb5f1a5b08e7893337376d723367858cc870404) Revert culture comparison ### 📊 Changes **40 files changed** (+183 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+5 -5) 📝 `MediaBrowser.Controller/Channels/IDisableMediaSourceDisplay.cs` (+7 -1) 📝 `MediaBrowser.Controller/Channels/ISupportsMediaProbe.cs` (+4 -1) 📝 `MediaBrowser.Controller/Entities/AggregateFolder.cs` (+3 -3) 📝 `MediaBrowser.Controller/Entities/Audio/Audio.cs` (+5 -4) 📝 `MediaBrowser.Controller/Entities/Audio/MusicArtist.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+24 -18) 📝 `MediaBrowser.Controller/Entities/CollectionFolder.cs` (+3 -3) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+13 -14) 📝 `MediaBrowser.Controller/Entities/Genre.cs` (+5 -1) 📝 `MediaBrowser.Controller/Entities/IHasScreenshots.cs` (+3 -1) 📝 `MediaBrowser.Controller/Entities/ISupportsBoxSetGrouping.cs` (+2 -0) 📝 `MediaBrowser.Controller/Entities/LinkedChildComparer.cs` (+2 -1) 📝 `MediaBrowser.Controller/Entities/TV/Episode.cs` (+4 -3) 📝 `MediaBrowser.Controller/Entities/TV/Season.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/UserRootFolder.cs` (+2 -2) 📝 `MediaBrowser.Controller/Entities/UserView.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/UserViewBuilder.cs` (+10 -8) 📝 `MediaBrowser.Controller/Entities/Video.cs` (+2 -1) 📝 `MediaBrowser.Controller/IO/FileData.cs` (+1 -1) _...and 20 more files_ </details> ### 📄 Description Part of #2149 Warning codes remaining: ``` CA1711 CA2227 CA1002 CA1819 SA1201 SA1622 CA1051 SA1401 SA1306 CA1008 CA1721 SA1214 CA2211 SA1203 CA1044 SA1615 SA1611 SA1618 SA1627 CA1707 SA1614 CA1508 SA1617 CA1826 CA1835 CA1033 CA1724 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 06:27:12 +03:00

OVERLORD closed this issue

2026-02-07 06:27:14 +03:00

OVERLORD referenced this issue

2026-02-07 06:59:00 +03:00

[PR #10816] chore(deps): update dependency playlistsnet to v1.4.1 #12619

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10816