[PR #6054] [MERGED] Reduce some allocations #10795

Closed
opened 2026-02-07 06:26:49 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6054
Author: @cvium
Created: 5/16/2021
Status: Merged
Merged: 5/20/2021
Merged by: @Bond-009

Base: masterHead: allocationz_2_extreme_db_plsdonthurtme


📝 Commits (9)

  • 1b49435 Reduce some allocations
  • eaafbdd Remove some leftover junk from a project that isn't in the sln
  • 415e8fc Forward
  • 652909e Update Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs
  • be4aeb5 Rename SQL extension methods
  • 81ac118 Fix ArrayIndexOutOfBounds
  • 1027792 Review changes
  • 7e6a45c Review changes
  • e0f7937 Fix build

📊 Changes

18 files changed (+729 additions, -544 deletions)

View changed files

📝 Emby.Naming/Audio/AudioFileParser.cs (+3 -3)
📝 Emby.Naming/Emby.Naming.csproj (+3 -2)
📝 Emby.Naming/Video/ExtraResolver.cs (+49 -46)
📝 Emby.Naming/Video/VideoResolver.cs (+10 -12)
📝 Emby.Server.Implementations/Data/BaseSqliteRepository.cs (+2 -4)
📝 Emby.Server.Implementations/Data/SqliteExtensions.cs (+101 -10)
📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+230 -340)
📝 Emby.Server.Implementations/Data/SqliteUserDataRepository.cs (+8 -8)
📝 Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs (+18 -18)
📝 Emby.Server.Implementations/Library/Resolvers/BaseVideoResolver.cs (+8 -8)
📝 Emby.Server.Implementations/Security/AuthenticationRepository.cs (+20 -21)
📝 Jellyfin.sln (+7 -0)
MediaBrowser.Common/Extensions/EnumerableExtensions.cs (+51 -0)
📝 MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs (+14 -3)
📝 MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs (+67 -68)
📝 tests/Jellyfin.Naming.Tests/Video/VideoResolverTests.cs (+5 -1)
tests/Jellyfin.Providers.Tests/Jellyfin.Providers.Tests.csproj (+37 -0)
tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs (+96 -0)

📄 Description

Changes
Reduce allocations by using spans and by reducing the number of times a column value is retrieved (effectively halved).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6054 **Author:** [@cvium](https://github.com/cvium) **Created:** 5/16/2021 **Status:** ✅ Merged **Merged:** 5/20/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `allocationz_2_extreme_db_plsdonthurtme` --- ### 📝 Commits (9) - [`1b49435`](https://github.com/jellyfin/jellyfin/commit/1b49435a0eb18595c84236fb8cf7671263f3c3cf) Reduce some allocations - [`eaafbdd`](https://github.com/jellyfin/jellyfin/commit/eaafbdd623feed3125c2ce7e3c44ec7b26b42a81) Remove some leftover junk from a project that isn't in the sln - [`415e8fc`](https://github.com/jellyfin/jellyfin/commit/415e8fc0f3b7f214fbcbdc8fa39a863b06690243) Forward - [`652909e`](https://github.com/jellyfin/jellyfin/commit/652909e8a57075866e56c270852e34714bf06c06) Update Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs - [`be4aeb5`](https://github.com/jellyfin/jellyfin/commit/be4aeb5c2cb7fa6e05810aa1d0c935b5166fb64a) Rename SQL extension methods - [`81ac118`](https://github.com/jellyfin/jellyfin/commit/81ac11828bbf9310a507af034b0d749323db3688) Fix ArrayIndexOutOfBounds - [`1027792`](https://github.com/jellyfin/jellyfin/commit/1027792b16996e3fe7e4835805204e8c91beda01) Review changes - [`7e6a45c`](https://github.com/jellyfin/jellyfin/commit/7e6a45c402988cba27c36cc6b1b339a4a52b732a) Review changes - [`e0f7937`](https://github.com/jellyfin/jellyfin/commit/e0f793799afccd4e2d640dbf5554f72d8a8f8b02) Fix build ### 📊 Changes **18 files changed** (+729 additions, -544 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Audio/AudioFileParser.cs` (+3 -3) 📝 `Emby.Naming/Emby.Naming.csproj` (+3 -2) 📝 `Emby.Naming/Video/ExtraResolver.cs` (+49 -46) 📝 `Emby.Naming/Video/VideoResolver.cs` (+10 -12) 📝 `Emby.Server.Implementations/Data/BaseSqliteRepository.cs` (+2 -4) 📝 `Emby.Server.Implementations/Data/SqliteExtensions.cs` (+101 -10) 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+230 -340) 📝 `Emby.Server.Implementations/Data/SqliteUserDataRepository.cs` (+8 -8) 📝 `Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs` (+18 -18) 📝 `Emby.Server.Implementations/Library/Resolvers/BaseVideoResolver.cs` (+8 -8) 📝 `Emby.Server.Implementations/Security/AuthenticationRepository.cs` (+20 -21) 📝 `Jellyfin.sln` (+7 -0) ➕ `MediaBrowser.Common/Extensions/EnumerableExtensions.cs` (+51 -0) 📝 `MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs` (+14 -3) 📝 `MediaBrowser.Providers/MediaInfo/SubtitleResolver.cs` (+67 -68) 📝 `tests/Jellyfin.Naming.Tests/Video/VideoResolverTests.cs` (+5 -1) ➕ `tests/Jellyfin.Providers.Tests/Jellyfin.Providers.Tests.csproj` (+37 -0) ➕ `tests/Jellyfin.Providers.Tests/MediaInfo/SubtitleResolverTests.cs` (+96 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Reduce allocations by using spans and by reducing the number of times a column value is retrieved (effectively halved). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:26:49 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10795