starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #6043] [MERGED] Reorder requested audio channels checks #10788

New Issue
Closed
opened 2026-02-07 06:26:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:26:43 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6043
Author: @peterspenler
Created: 5/13/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @cvium

Base: master ← Head: feature/chromecast-aac-handling

📝 Commits (1)

  • 3c981cf Reorder requested audio channels checks

📊 Changes

2 files changed (+11 additions, -10 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.Controller/MediaEncoding/EncodingJobInfo.cs (+10 -10)

📄 Description

Changes
Reordered the requested audio checks in encoding job info. Some devices have device specific channel limits for certain audio codecs which they request through the {codecName}-audiochannels query parameter. For example chromecasts can only handle up to 2 channels when using AAC audio. These request options should override the normal channel limits.

Issues
Fixes #5795

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6043 **Author:** [@peterspenler](https://github.com/peterspenler) **Created:** 5/13/2021 **Status:** ✅ Merged **Merged:** 5/24/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `feature/chromecast-aac-handling` --- ### 📝 Commits (1) - [`3c981cf`](https://github.com/jellyfin/jellyfin/commit/3c981cf41f2a8e498e674dc707f15b4ebb2679ae) Reorder requested audio channels checks ### 📊 Changes **2 files changed** (+11 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingJobInfo.cs` (+10 -10) </details> ### 📄 Description **Changes** Reordered the requested audio checks in encoding job info. Some devices have device specific channel limits for certain audio codecs which they request through the `{codecName}-audiochannels` query parameter. For example chromecasts can only handle up to 2 channels when using AAC audio. These request options should override the normal channel limits. **Issues** Fixes #5795 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:26:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?