starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6033] [MERGED] Call TMDb Person API with metadata language #10783

New Issue
Closed
opened 2026-02-07 06:26:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:26:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6033
Author: @daullmer
Created: 5/12/2021
Status: ✅ Merged
Merged: 5/20/2021
Merged by: @Bond-009

Base: master ← Head: tmdb-person-language

📝 Commits (5)

  • c584d36 Fix Tmdb person language
  • 96e05e5 Add tests for NoralizeLanguage
  • 6353966 Fix cache key
  • ee7a95e Move GetMetadataLanguage
  • a7b7ff0 Merge branch 'master' into tmdb-person-language

📊 Changes

6 files changed (+44 additions, -11 deletions)

View changed files

📝 MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonImageProvider.cs (+2 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonProvider.cs (+2 -3)
📝 MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs (+4 -2)
📝 MediaBrowser.Providers/Plugins/Tmdb/TmdbUtils.cs (+6 -0)
📝 tests/Jellyfin.Providers.Tests/Jellyfin.Providers.Tests.csproj (+3 -3)
➕ tests/Jellyfin.Providers.Tests/Tmdb/TmdbUtilsTests.cs (+27 -0)

📄 Description

Changes
Persons always had their English biography instead of the localized one.
I also changed the NormalizeLanguage method because the TMDb API doesn't support de-CH, fr-CH and it-CH, so it now uses the language without the country code.

Issues
Fixes #6015

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6033 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 5/12/2021 **Status:** ✅ Merged **Merged:** 5/20/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `tmdb-person-language` --- ### 📝 Commits (5) - [`c584d36`](https://github.com/jellyfin/jellyfin/commit/c584d36fd4a643cfd252eddabbda8a91c2d8e0da) Fix Tmdb person language - [`96e05e5`](https://github.com/jellyfin/jellyfin/commit/96e05e5b669e0d275b98bebfd9dd422dcc8f7103) Add tests for NoralizeLanguage - [`6353966`](https://github.com/jellyfin/jellyfin/commit/6353966abdc31a7806c6d4d62154cf3da7c86adf) Fix cache key - [`ee7a95e`](https://github.com/jellyfin/jellyfin/commit/ee7a95e088520f835a4d179c7c5faec5eaa8f9ff) Move GetMetadataLanguage - [`a7b7ff0`](https://github.com/jellyfin/jellyfin/commit/a7b7ff000bdff1f089dc9d68347058fe8314f509) Merge branch 'master' into tmdb-person-language ### 📊 Changes **6 files changed** (+44 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonImageProvider.cs` (+2 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/People/TmdbPersonProvider.cs` (+2 -3) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs` (+4 -2) 📝 `MediaBrowser.Providers/Plugins/Tmdb/TmdbUtils.cs` (+6 -0) 📝 `tests/Jellyfin.Providers.Tests/Jellyfin.Providers.Tests.csproj` (+3 -3) ➕ `tests/Jellyfin.Providers.Tests/Tmdb/TmdbUtilsTests.cs` (+27 -0) </details> ### 📄 Description **Changes** Persons always had their English biography instead of the localized one. I also changed the `NormalizeLanguage` method because the TMDb API doesn't support de-CH, fr-CH and it-CH, so it now uses the language without the country code. **Issues** Fixes #6015 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:26:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10783
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?