starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #6025] [MERGED] Test LocalizationManager #10779

New Issue
Closed
opened 2026-02-07 06:26:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:26:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/6025
Author: @daullmer
Created: 5/10/2021
Status: ✅ Merged
Merged: 8/11/2021
Merged by: @cvium

Base: master ← Head: localization-test

📝 Commits (9)

  • 88bfd1b Add tests for LocalizationManager
  • db2b53a Refactor LocalizationManager and remove dead method
  • e33e3ba Make localizationManager local instead of field
  • 77aee51 Use correct string comparison
  • 6b61b50 Revert "Refactor LocalizationManager and remove dead method"
  • b5880c2 Minor improvements
  • 45e0f78 Merge remote-tracking branch 'upstream/master' into localization-test
  • d7c9b14 Apply suggestions from code review
  • 3a47ad1 Apply suggestions from code review

📊 Changes

2 files changed (+246 additions, -74 deletions)

View changed files

📝 Emby.Server.Implementations/Localization/LocalizationManager.cs (+67 -74)
➕ tests/Jellyfin.Server.Implementations.Tests/Localization/LocalizationManagerTests.cs (+179 -0)

📄 Description

Changes
Test coverage only goes one way 📈
Order LocalizationManager so public methods are before private methods
Use using declarations
Add 1 to index instead of using TrimStart(':')

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/6025 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 5/10/2021 **Status:** ✅ Merged **Merged:** 8/11/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `localization-test` --- ### 📝 Commits (9) - [`88bfd1b`](https://github.com/jellyfin/jellyfin/commit/88bfd1bcf45bdfa6c64e3439d7f406799645163c) Add tests for LocalizationManager - [`db2b53a`](https://github.com/jellyfin/jellyfin/commit/db2b53a4b52d0c1e9797bfc70030b04421ba46a6) Refactor LocalizationManager and remove dead method - [`e33e3ba`](https://github.com/jellyfin/jellyfin/commit/e33e3ba61037b594fd9035550e3ca646bb7f2c8f) Make localizationManager local instead of field - [`77aee51`](https://github.com/jellyfin/jellyfin/commit/77aee515a25b04d53aea05302209121daa33923b) Use correct string comparison - [`6b61b50`](https://github.com/jellyfin/jellyfin/commit/6b61b50b5331a3b088fa9fd5e742962dcb9b5b0b) Revert "Refactor LocalizationManager and remove dead method" - [`b5880c2`](https://github.com/jellyfin/jellyfin/commit/b5880c26808a6d7f183acb3f7977b42e13ccbf8a) Minor improvements - [`45e0f78`](https://github.com/jellyfin/jellyfin/commit/45e0f7893ba8f53827983109557447d2c0c8adcf) Merge remote-tracking branch 'upstream/master' into localization-test - [`d7c9b14`](https://github.com/jellyfin/jellyfin/commit/d7c9b141758c0cb2d1dd708fe4ce625b95d64434) Apply suggestions from code review - [`3a47ad1`](https://github.com/jellyfin/jellyfin/commit/3a47ad11e9b8b229026e2fe479a0012861a4e5bd) Apply suggestions from code review ### 📊 Changes **2 files changed** (+246 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Localization/LocalizationManager.cs` (+67 -74) ➕ `tests/Jellyfin.Server.Implementations.Tests/Localization/LocalizationManagerTests.cs` (+179 -0) </details> ### 📄 Description **Changes** Test coverage only goes one way 📈 Order LocalizationManager so public methods are before private methods Use using declarations Add 1 to index instead of using `TrimStart(':')` **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:26:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?