starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5997] [MERGED] Fixes for Book Progress #10770

New Issue
Closed
opened 2026-02-07 06:26:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:26:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5997
Author: @ThatsOurJake
Created: 5/6/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @cvium

Base: master ← Head: master

📝 Commits (2)

  • 3cd57cb Fixes for Book Progress
  • bc01773 Changed condition for readbility

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Emby.Server.Implementations/Library/UserDataManager.cs (+2 -2)

📄 Description

Changes
This PR moves the check for if it's a type Book when saving the progress to the database. Currently due to the maths the book progress will be below the default configs MinResumePct so this will just ignore books and save the progress without resetting it to 0.

Issues
Didn't see an issue for this. But it occurs when you have books on your Jellyfin, read through a few pages and then back out the PDF viewer the progress isn't saved and upon refreshing the page the progress is still 0.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5997 **Author:** [@ThatsOurJake](https://github.com/ThatsOurJake) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/24/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3cd57cb`](https://github.com/jellyfin/jellyfin/commit/3cd57cb28703a078cc4c03e0af53a6b2e166a679) Fixes for Book Progress - [`bc01773`](https://github.com/jellyfin/jellyfin/commit/bc017737e678c62a1573fa9c8820fc4fd2b97405) Changed condition for readbility ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/UserDataManager.cs` (+2 -2) </details> ### 📄 Description **Changes** This PR moves the check for if it's a type `Book` when saving the progress to the database. Currently due to the maths the book progress will be below the default configs `MinResumePct` so this will just ignore books and save the progress without resetting it to 0. **Issues** Didn't see an issue for this. But it occurs when you have books on your Jellyfin, read through a few pages and then back out the PDF viewer the progress isn't saved and upon refreshing the page the progress is still 0. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:26:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?