starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5921] [CLOSED] DeviceProfile comments, optimization, etc. #10735

New Issue
Closed
opened 2026-02-07 06:25:48 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:25:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5921
Author: @BaronGreenback
Created: 4/26/2021
Status: ❌ Closed

Base: master ← Head: DlnaPreWork

📝 Commits (7)

📊 Changes

2 files changed (+52 additions, -38 deletions)

View changed files

📝 MediaBrowser.Model/Dlna/DeviceProfile.cs (+50 -37)
📝 MediaBrowser.Model/Dlna/DeviceProfileType.cs (+2 -1)

📄 Description

Optimization
Removed a method that cloned an object which was then only ever used for comparison purposes.

Fixed
EncodeContextOnTransmission was never fully implemented in the existing code. It permits unencoded didl traffic to be transmitted to the device.

New
Used by a new feature called temporary profiles.

By optionally linking dlna playTo with the dlna server, the reported properties of the device are available, instead of the only the http headers.

Feature is implemented in the plugin - however, this file cannot be moved into the plugin in phase 1.

Has no impact at all in the current code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5921 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 4/26/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `DlnaPreWork` --- ### 📝 Commits (7) - [`7c42086`](https://github.com/jellyfin/jellyfin/commit/7c42086db0fd7acb5b48be020950e54d20c59912) Added properties in preparation. - [`6857678`](https://github.com/jellyfin/jellyfin/commit/6857678e13854fd5e6e0993ba8a2a6a491fade32) Update DeviceProfile.cs - [`8ab475f`](https://github.com/jellyfin/jellyfin/commit/8ab475f1e92232ab7027982d38f48064d9dbe383) removed duplicate - [`d001653`](https://github.com/jellyfin/jellyfin/commit/d00165317a2483452906a71fa4ffefff9e0798ae) Merge branch 'master' into DlnaPreWork - [`f38e641`](https://github.com/jellyfin/jellyfin/commit/f38e64101184b66fd7e9eaf13a3e6d91d6b4c42a) corrected nullability - [`d8e08e4`](https://github.com/jellyfin/jellyfin/commit/d8e08e4a2c88758fc489dabd12717e1c14c1346d) Update DeviceProfile.cs - [`58fdd8b`](https://github.com/jellyfin/jellyfin/commit/58fdd8bfb9cdcad22a86fa51d9fa2a7eb2bef6f1) Update DeviceProfile.cs ### 📊 Changes **2 files changed** (+52 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Model/Dlna/DeviceProfile.cs` (+50 -37) 📝 `MediaBrowser.Model/Dlna/DeviceProfileType.cs` (+2 -1) </details> ### 📄 Description **Optimization** Removed a method that cloned an object which was then only ever used for comparison purposes. **Fixed** EncodeContextOnTransmission was never fully implemented in the existing code. It permits unencoded didl traffic to be transmitted to the device. **New** Used by a new feature called temporary profiles. By optionally linking dlna playTo with the dlna server, the reported properties of the device are available, instead of the only the http headers. Feature is implemented in the plugin - however, this file cannot be moved into the plugin in phase 1. Has no impact at all in the current code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:25:49 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?