starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5873] [MERGED] Check for empty string when migrating displaypreferences #10699

New Issue
Closed
opened 2026-02-07 06:25:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:25:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5873
Author: @cvium
Created: 4/20/2021
Status: ✅ Merged
Merged: 4/20/2021
Merged by: @Bond-009

Base: master ← Head: fix-displaypref-migration

📝 Commits (2)

  • cbb855e Check for empty string when migrating displaypreferences
  • 4d7c1fb use int.Parse

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 Jellyfin.Server/Migrations/Routines/MigrateDisplayPreferencesDb.cs (+5 -5)

📄 Description

Changes
Some values were empty strings, which causes int.Parse to crash

Issues
Fixes https://github.com/jellyfin/jellyfin/issues/5473#issuecomment-817184184

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5873 **Author:** [@cvium](https://github.com/cvium) **Created:** 4/20/2021 **Status:** ✅ Merged **Merged:** 4/20/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `fix-displaypref-migration` --- ### 📝 Commits (2) - [`cbb855e`](https://github.com/jellyfin/jellyfin/commit/cbb855e65fd56d44b6e5714dd6843bb1d9dee1b8) Check for empty string when migrating displaypreferences - [`4d7c1fb`](https://github.com/jellyfin/jellyfin/commit/4d7c1fbdca44eb6e892b104b765b86e146ac9765) use int.Parse ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server/Migrations/Routines/MigrateDisplayPreferencesDb.cs` (+5 -5) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Some values were empty strings, which causes `int.Parse` to crash **Issues** Fixes https://github.com/jellyfin/jellyfin/issues/5473#issuecomment-817184184 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:25:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?