[PR #5861] [MERGED] Change profile matching to match what the web interface says. #10692

Closed
opened 2026-02-07 06:25:04 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5861
Author: @BaronGreenback
Created: 4/19/2021
Status: Merged
Merged: 4/25/2021
Merged by: @cvium

Base: masterHead: ProfileMatch


📝 Commits (10+)

📊 Changes

3 files changed (+163 additions, -66 deletions)

View changed files

📝 Emby.Dlna/DlnaManager.cs (+30 -65)
tests/Jellyfin.Dlna.Tests/DlnaManagerTests.cs (+131 -0)
📝 tests/Jellyfin.Dlna.Tests/Jellyfin.Dlna.Tests.csproj (+2 -1)

📄 Description

https://github.com/jellyfin/jellyfin/issues/5854

Web interfaces says""Enter at least one identification criteria".

Currently profiles are being matched on all criteria.

This PR - changes the profile matching to what the web says and includes a test.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5861 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 4/19/2021 **Status:** ✅ Merged **Merged:** 4/25/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `ProfileMatch` --- ### 📝 Commits (10+) - [`c68f616`](https://github.com/jellyfin/jellyfin/commit/c68f6163774e4d6534a5a68d2c0f6b7435240ed3) Flip fields - [`95b733a`](https://github.com/jellyfin/jellyfin/commit/95b733ad4cbbe35b638de51e0b84d2794d28c34d) reworked code - [`4449217`](https://github.com/jellyfin/jellyfin/commit/4449217f8ff736e98a50fc686331c5240f6fe33c) simplified isMatch - [`092c610`](https://github.com/jellyfin/jellyfin/commit/092c610fbf8268d5ff4518c2a6882764b89183d1) Update Emby.Dlna/DlnaManager.cs - [`a99caa0`](https://github.com/jellyfin/jellyfin/commit/a99caa0daae7c47afdf7d0cf5cf182976211ffa2) Changed testing - [`7848ea1`](https://github.com/jellyfin/jellyfin/commit/7848ea148438baf8929e1c2939e6979cb84aad1a) missed one. - [`f8b717e`](https://github.com/jellyfin/jellyfin/commit/f8b717e7c51a771b937312af3f1aa77e044b86ce) Merge branch 'master' into ProfileMatch - [`4124690`](https://github.com/jellyfin/jellyfin/commit/41246909dcbf71a85140b5354e5f76e33ea4801e) fixed merge - [`522d5a7`](https://github.com/jellyfin/jellyfin/commit/522d5a71582fa4b610c75b0029812a9c10619002) Fixed indent - [`2559cef`](https://github.com/jellyfin/jellyfin/commit/2559ceffab778933a6122d2989cfa4d58f699839) Update tests/Jellyfin.Dlna.Tests/ProfileTester.cs ### 📊 Changes **3 files changed** (+163 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/DlnaManager.cs` (+30 -65) ➕ `tests/Jellyfin.Dlna.Tests/DlnaManagerTests.cs` (+131 -0) 📝 `tests/Jellyfin.Dlna.Tests/Jellyfin.Dlna.Tests.csproj` (+2 -1) </details> ### 📄 Description https://github.com/jellyfin/jellyfin/issues/5854 Web interfaces says""Enter at least one identification criteria". Currently profiles are being matched on **all** criteria. This PR - changes the profile matching to what the web says and includes a test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:25:04 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10692