starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5844] [CLOSED] Code Clean up: Remove redundant 'else' keywords #10689

New Issue
Closed
opened 2026-02-07 06:24:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:24:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5844
Author: @BaronGreenback
Created: 4/17/2021
Status: ❌ Closed

Base: master ← Head: redundantElses

📝 Commits (1)

  • d98e70e Remove redundant 'else' keywords

📊 Changes

20 files changed (+161 additions, -141 deletions)

View changed files

📝 Emby.Server.Implementations/Data/SqliteItemRepository.cs (+58 -29)
📝 Emby.Server.Implementations/Library/MediaSourceManager.cs (+2 -4)
📝 Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs (+2 -4)
📝 Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs (+4 -5)
📝 Emby.Server.Implementations/SyncPlay/Group.cs (+4 -8)
📝 Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs (+2 -4)
📝 Jellyfin.Api/Controllers/SubtitleController.cs (+2 -4)
📝 Jellyfin.Networking/Manager/NetworkManager.cs (+6 -6)
📝 MediaBrowser.Common/Cryptography/PasswordHash.cs (+2 -1)
📝 MediaBrowser.Common/System/OperatingSystem.cs (+4 -2)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+9 -13)
📝 MediaBrowser.Controller/LiveTv/LiveTvProgram.cs (+2 -4)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+8 -7)
📝 MediaBrowser.Controller/Sorting/AlphanumComparator.cs (+16 -8)
📝 MediaBrowser.Controller/SyncPlay/GroupStates/WaitingGroupState.cs (+3 -5)
📝 MediaBrowser.Controller/SyncPlay/Queue/PlayQueueManager.cs (+11 -18)
📝 MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs (+2 -4)
📝 MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs (+4 -2)
📝 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs (+4 -5)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+16 -8)

📄 Description

As per ReSharper: No extra code added.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5844 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 4/17/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `redundantElses` --- ### 📝 Commits (1) - [`d98e70e`](https://github.com/jellyfin/jellyfin/commit/d98e70eaf1a03ac5bec157a6bce394382450dd48) Remove redundant 'else' keywords ### 📊 Changes **20 files changed** (+161 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/SqliteItemRepository.cs` (+58 -29) 📝 `Emby.Server.Implementations/Library/MediaSourceManager.cs` (+2 -4) 📝 `Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs` (+2 -4) 📝 `Emby.Server.Implementations/LiveTv/Listings/SchedulesDirect.cs` (+4 -5) 📝 `Emby.Server.Implementations/SyncPlay/Group.cs` (+4 -8) 📝 `Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs` (+2 -4) 📝 `Jellyfin.Api/Controllers/SubtitleController.cs` (+2 -4) 📝 `Jellyfin.Networking/Manager/NetworkManager.cs` (+6 -6) 📝 `MediaBrowser.Common/Cryptography/PasswordHash.cs` (+2 -1) 📝 `MediaBrowser.Common/System/OperatingSystem.cs` (+4 -2) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+9 -13) 📝 `MediaBrowser.Controller/LiveTv/LiveTvProgram.cs` (+2 -4) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+8 -7) 📝 `MediaBrowser.Controller/Sorting/AlphanumComparator.cs` (+16 -8) 📝 `MediaBrowser.Controller/SyncPlay/GroupStates/WaitingGroupState.cs` (+3 -5) 📝 `MediaBrowser.Controller/SyncPlay/Queue/PlayQueueManager.cs` (+11 -18) 📝 `MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs` (+2 -4) 📝 `MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs` (+4 -2) 📝 `MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs` (+4 -5) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+16 -8) </details> ### 📄 Description As per ReSharper: No extra code added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:24:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?