starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5717] [MERGED] make custompref value nullable #10625

New Issue
Closed
opened 2026-02-07 06:23:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:23:44 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5717
Author: @cvium
Created: 4/7/2021
Status: ✅ Merged
Merged: 4/8/2021
Merged by: @Bond-009

Base: master ← Head: nullable-custompref-value

📝 Commits (2)

📊 Changes

6 files changed (+563 additions, -10 deletions)

View changed files

📝 Jellyfin.Data/Entities/CustomItemDisplayPreferences.cs (+2 -2)
➕ Jellyfin.Server.Implementations/Migrations/20210407110544_NullableCustomPrefValue.Designer.cs (+520 -0)
➕ Jellyfin.Server.Implementations/Migrations/20210407110544_NullableCustomPrefValue.cs (+35 -0)
📝 Jellyfin.Server.Implementations/Migrations/JellyfinDbModelSnapshot.cs (+4 -6)
📝 Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs (+1 -1)
📝 MediaBrowser.Controller/IDisplayPreferencesManager.cs (+1 -1)

📄 Description

Changes
some clients send a null value. It has been discussed whether it should be nullable in the DB or if we handle it outside the DB.

Making the column nullable is simpler imo. If it's not nullable we have to remove any nulled rows from the db and skip if it doesn't already exist etc.

Issues
Fixes https://github.com/jellyfin/jellyfin/issues/5679

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5717 **Author:** [@cvium](https://github.com/cvium) **Created:** 4/7/2021 **Status:** ✅ Merged **Merged:** 4/8/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `nullable-custompref-value` --- ### 📝 Commits (2) - [`d772fdd`](https://github.com/jellyfin/jellyfin/commit/d772fddfb3fcddd5f540cf2650eb7e405a6aec2c) make custompref value nullable - [`4892e0c`](https://github.com/jellyfin/jellyfin/commit/4892e0cf064a2a392881b38a5965324aa80eac0c) fix build...somehow ### 📊 Changes **6 files changed** (+563 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Data/Entities/CustomItemDisplayPreferences.cs` (+2 -2) ➕ `Jellyfin.Server.Implementations/Migrations/20210407110544_NullableCustomPrefValue.Designer.cs` (+520 -0) ➕ `Jellyfin.Server.Implementations/Migrations/20210407110544_NullableCustomPrefValue.cs` (+35 -0) 📝 `Jellyfin.Server.Implementations/Migrations/JellyfinDbModelSnapshot.cs` (+4 -6) 📝 `Jellyfin.Server.Implementations/Users/DisplayPreferencesManager.cs` (+1 -1) 📝 `MediaBrowser.Controller/IDisplayPreferencesManager.cs` (+1 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** some clients send a null value. It has been discussed whether it should be nullable in the DB or if we handle it outside the DB. Making the column nullable is simpler imo. If it's not nullable we have to remove any nulled rows from the db and skip if it doesn't already exist etc. **Issues** Fixes https://github.com/jellyfin/jellyfin/issues/5679 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:23:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10625
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?