starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5648] [MERGED] Fix session references in SyncPlay #10584

New Issue
Closed
opened 2026-02-07 06:22:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5648
Author: @OancaAndrei
Created: 3/29/2021
Status: ✅ Merged
Merged: 9/10/2021
Merged by: @cvium

Base: master ← Head: syncplay-sessions-fix

📝 Commits (3)

  • 9eb740b Fix storing outdated sessions in SyncPlay
  • 776ce7c Send playing item status in SyncPlay group update
  • f6c0db4 merge branch 'master' into syncplay-sessions-fix

📊 Changes

6 files changed (+58 additions, -31 deletions)

View changed files

📝 Emby.Server.Implementations/Session/SessionManager.cs (+4 -2)
📝 Emby.Server.Implementations/SyncPlay/Group.cs (+18 -16)
📝 Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs (+4 -4)
📝 MediaBrowser.Controller/Session/ISessionManager.cs (+4 -4)
📝 MediaBrowser.Controller/SyncPlay/GroupMember.cs (+19 -4)
📝 MediaBrowser.Model/SyncPlay/PlayQueueUpdate.cs (+9 -1)

📄 Description

Changes

  • Reverting implementation to use the identifiers of the sessions instead of SessionInfo objects directly as the latter are not always updated by SessionManager.
    Clients can now reload the page and receive SyncPlay updates again.
  • Send playing item status (IsPlaying) to clients (needed for correct playback initialization).

Issues

Should fix #5557.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5648 **Author:** [@OancaAndrei](https://github.com/OancaAndrei) **Created:** 3/29/2021 **Status:** ✅ Merged **Merged:** 9/10/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `syncplay-sessions-fix` --- ### 📝 Commits (3) - [`9eb740b`](https://github.com/jellyfin/jellyfin/commit/9eb740ba57c7d8dfbffac9e18541c969eb0af880) Fix storing outdated sessions in SyncPlay - [`776ce7c`](https://github.com/jellyfin/jellyfin/commit/776ce7c660a6d6bf975766378d6db7124f4ac232) Send playing item status in SyncPlay group update - [`f6c0db4`](https://github.com/jellyfin/jellyfin/commit/f6c0db4bb5007182d79ceb809675b90909fd1fa0) merge branch 'master' into syncplay-sessions-fix ### 📊 Changes **6 files changed** (+58 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+4 -2) 📝 `Emby.Server.Implementations/SyncPlay/Group.cs` (+18 -16) 📝 `Emby.Server.Implementations/SyncPlay/SyncPlayManager.cs` (+4 -4) 📝 `MediaBrowser.Controller/Session/ISessionManager.cs` (+4 -4) 📝 `MediaBrowser.Controller/SyncPlay/GroupMember.cs` (+19 -4) 📝 `MediaBrowser.Model/SyncPlay/PlayQueueUpdate.cs` (+9 -1) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> - Reverting implementation to use the identifiers of the sessions instead of `SessionInfo` objects directly as the latter are not always updated by `SessionManager`. Clients can now reload the page and receive SyncPlay updates again. - Send playing item status (`IsPlaying`) to clients (needed for correct playback initialization). **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Should fix #5557. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?