mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #5631] [MERGED] Fix SessionController.SendMessageCommand Body Binding #10583
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/5631
Author: @BrianCArnold
Created: 3/26/2021
Status: ✅ Merged
Merged: 4/7/2021
Merged by: @cvium
Base:
master← Head:FixMessageCommand📝 Commits (9)
81e3e5cChanged SessionController.SendMessageCommandf114ba5Fixed comment and code block runes to match coding998833eRemoved null check for body object and user [Required] attribute in replacement.ca25301Added Required attribute to Text property of MessageCommand.54107aeFix spacing requirement for MessageCommand.80fe48fUpdate SessionController.csaf03b28Update SessionController.cs4fa2a32Apply suggestions from code review3820671Merge remote-tracking branch 'main/master' into FixMessageCommand📊 Changes
2 files changed (+8 additions, -11 deletions)
View changed files
📝
Jellyfin.Api/Controllers/SessionController.cs(+5 -11)📝
MediaBrowser.Model/Session/MessageCommand.cs(+3 -0)📄 Description
Changed SessionController.SendMessageCommand to bind information to composite object instead query string parameters.
Changes
Changes selected parameter binding of SendMessageCommand to a single composite object bound by [FromBody].
Issues
Resolves: #5628
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.