mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-05-04 18:09:12 +03:00
[PR #5629] [MERGED] Fix stream selection having no effect when casting to jellyfin-mpv-shim #10580
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/5629
Author: @lmaonator
Created: 3/26/2021
Status: ✅ Merged
Merged: 3/27/2021
Merged by: @cvium
Base:
master← Head:fix-cast-stream-selection📝 Commits (2)
db2fbceFix stream selection having no effect when casting694d772Update Jellyfin.Api/Controllers/SessionController.cs📊 Changes
1 file changed (+14 additions, -2 deletions)
View changed files
📝
Jellyfin.Api/Controllers/SessionController.cs(+14 -2)📄 Description
When casting to jellyfin-mpv-shim from jellyfin-web in the browser,
jellyfin-web sends data about which version (for grouped items) and
which streams the user selected in the browser to the
"Sessions/{sessionId}/Playing" API endpoint.
The API endpoint currently doesn't forward them to the cast client
through the Play command, which results in the default streams being
played instead of the streams selected in the browser.
PlayRequest already has the properties and they are already sent to the
cast client by SendPlayCommand when present.
jellyfin-mpv-shim will already use them to select the wanted streams
when it receives the Play command.
Changes
All that's needed to make it work is to take the parameters and assign
them to PlayRequest.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.