starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5622] [CLOSED] Set streamState property to what the code expects. #10577

New Issue
Closed
opened 2026-02-07 06:22:51 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5622
Author: @BaronGreenback
Created: 3/26/2021
Status: ❌ Closed

Base: master ← Head: FileTypeUnknownFix

📝 Commits (1)

  • 5fc3604 Update StreamingHelpers.cs

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Jellyfin.Api/Helpers/StreamingHelpers.cs (+1 -1)

📄 Description

Don't know what issue is caused by the current code, but StreamState.RequestedUrl is currently set to the file extension of the Uri.

The code isn't expecting this, and isn't working as designed later, when it's checked for its url value.

Investigated further.

By url only being set to the file extension part of the request - eg. avi if http://1.1.1.1/web/film.avi (line 91)
the function StreamingHelper.cs / GetOutputFileExtension will always calculate the extension.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5622 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 3/26/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `FileTypeUnknownFix` --- ### 📝 Commits (1) - [`5fc3604`](https://github.com/jellyfin/jellyfin/commit/5fc36042921229ef9c9be797f7fdd3ea85f0c5fc) Update StreamingHelpers.cs ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Helpers/StreamingHelpers.cs` (+1 -1) </details> ### 📄 Description Don't know what issue is caused by the current code, but StreamState.RequestedUrl is currently set to the file extension of the Uri. The code isn't expecting this, and isn't working as designed later, when it's checked for its url value. Investigated further. By url only being set to the file extension part of the request - eg. avi if http://1.1.1.1/web/film.avi (line 91) the function StreamingHelper.cs / GetOutputFileExtension will always calculate the extension. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?