starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5596] [MERGED] Implemented DLNA exception handling #10570

New Issue
Closed
opened 2026-02-07 06:22:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5596
Author: @BaronGreenback
Created: 3/22/2021
Status: ✅ Merged
Merged: 3/25/2021
Merged by: @Bond-009

Base: master ← Head: DLNA_Hardening

📝 Commits (1)

📊 Changes

4 files changed (+51 additions, -14 deletions)

View changed files

📝 Emby.Dlna/PlayTo/Device.cs (+33 -8)
📝 Emby.Dlna/PlayTo/PlayToManager.cs (+5 -0)
📝 Emby.Dlna/PlayTo/SsdpHttpClient.cs (+11 -4)
📝 tests/Jellyfin.Networking.Tests/NetworkParseTests.cs (+2 -2)

📄 Description

Badly formed XML responses from devices cause exceptions and crashing JF.

This fix wraps the http request in a try/catch handler, and returns null.
All methods down the line using this function have had addition null checks adding.

Fixes https://github.com/jellyfin/jellyfin/issues/5560

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5596 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 3/22/2021 **Status:** ✅ Merged **Merged:** 3/25/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `DLNA_Hardening` --- ### 📝 Commits (1) - [`4bd345f`](https://github.com/jellyfin/jellyfin/commit/4bd345fbabd7832bcb91a920ec81dc14a7420218) DLNA Exception catching ### 📊 Changes **4 files changed** (+51 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/PlayTo/Device.cs` (+33 -8) 📝 `Emby.Dlna/PlayTo/PlayToManager.cs` (+5 -0) 📝 `Emby.Dlna/PlayTo/SsdpHttpClient.cs` (+11 -4) 📝 `tests/Jellyfin.Networking.Tests/NetworkParseTests.cs` (+2 -2) </details> ### 📄 Description Badly formed XML responses from devices cause exceptions and crashing JF. This fix wraps the http request in a try/catch handler, and returns null. All methods down the line using this function have had addition null checks adding. Fixes https://github.com/jellyfin/jellyfin/issues/5560 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?