[PR #5602] [MERGED] Don't convert from IPAddress to string to IPAddress #10568

New Issue

OVERLORD · 2026-02-07T06:22:40+03:00

OVERLORD commented

2026-02-07 06:22:40 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5602
Author: @daullmer
Created: 3/23/2021
Status: ✅ Merged
Merged: 4/3/2021
Merged by: @Bond-009

Base: master ← Head: IP-string-IP

📝 Commits (2)

19e4ef8 Remove conversion from IPAddress to string to IPAddress
c2af50c Add tests for IsInNetwork

📊 Changes

9 files changed (+92 additions, -42 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/Security/SessionContext.cs (+1 -1)
📝 Jellyfin.Api/Controllers/UserController.cs (+18 -7)
📝 Jellyfin.Api/Helpers/DynamicHlsHelper.cs (+1 -1)
📝 Jellyfin.Api/Helpers/MediaInfoHelper.cs (+3 -2)
📝 Jellyfin.Api/Helpers/RequestHelpers.cs (+1 -1)
📝 MediaBrowser.Common/Extensions/HttpContextExtensions.cs (+2 -2)
📝 tests/Jellyfin.Api.Tests/Auth/LocalAccessPolicy/LocalAccessHandlerTests.cs (+2 -1)
➕ tests/Jellyfin.Networking.Tests/NetworkManagerTests.cs (+63 -0)
📝 tests/Jellyfin.Networking.Tests/NetworkParseTests.cs (+1 -27)

📄 Description

Changes

Unnecessary change of data type which could lead to the wrong IP address being parsed (IsInNetwork has an overload for string and IPAddress)
Add log warning if Password Reset is initiated from outside the local network
Add tests for IsInNetwork

Issues
Code from #5180

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5602 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 3/23/2021 **Status:** ✅ Merged **Merged:** 4/3/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `IP-string-IP` --- ### 📝 Commits (2) - [`19e4ef8`](https://github.com/jellyfin/jellyfin/commit/19e4ef82dda1cbba9d533047950afb42c425749a) Remove conversion from IPAddress to string to IPAddress - [`c2af50c`](https://github.com/jellyfin/jellyfin/commit/c2af50c51dd4d49ce44604ba5b34d77fad01a130) Add tests for IsInNetwork ### 📊 Changes **9 files changed** (+92 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/Security/SessionContext.cs` (+1 -1) 📝 `Jellyfin.Api/Controllers/UserController.cs` (+18 -7) 📝 `Jellyfin.Api/Helpers/DynamicHlsHelper.cs` (+1 -1) 📝 `Jellyfin.Api/Helpers/MediaInfoHelper.cs` (+3 -2) 📝 `Jellyfin.Api/Helpers/RequestHelpers.cs` (+1 -1) 📝 `MediaBrowser.Common/Extensions/HttpContextExtensions.cs` (+2 -2) 📝 `tests/Jellyfin.Api.Tests/Auth/LocalAccessPolicy/LocalAccessHandlerTests.cs` (+2 -1) ➕ `tests/Jellyfin.Networking.Tests/NetworkManagerTests.cs` (+63 -0) 📝 `tests/Jellyfin.Networking.Tests/NetworkParseTests.cs` (+1 -27) </details> ### 📄 Description **Changes** - Unnecessary change of data type which could lead to the wrong IP address being parsed (IsInNetwork has an overload for string and IPAddress) - Add log warning if Password Reset is initiated from outside the local network - Add tests for IsInNetwork **Issues** Code from #5180 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 06:22:40 +03:00

OVERLORD closed this issue

2026-02-07 06:22:42 +03:00

Sign in to join this conversation.

Branches Tags

master

release-10.11.z

renovate/skiasharp-monorepo

JPVenson-patch-1

renovate/morestachio-5.x

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10568