starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5556] [MERGED] Add «resize to fill box» alternative for image endpoints #10559

New Issue
Closed
opened 2026-02-07 06:22:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5556
Author: @oddstr13
Created: 3/17/2021
Status: ✅ Merged
Merged: 4/11/2021
Merged by: @Bond-009

Base: master ← Head: image-fill-resize

📝 Commits (6)

  • 383aa4e Add Resize to fill box alternative to image endpoints
  • 13d0837 (mostly)Fix ResizeFill
  • e57c165 Remove GetSizeEstimate & GetEstimatedAspectRatio
  • afff226 Apply suggestions from code review
  • e0edbc5 Apply suggestions from code review
  • d0857cf Fix build, increase StringBuilder starting size

📊 Changes

5 files changed (+253 additions, -81 deletions)

View changed files

📝 Emby.Drawing/ImageProcessor.cs (+96 -17)
📝 Jellyfin.Api/Controllers/ImageController.cs (+96 -4)
📝 MediaBrowser.Controller/Drawing/ImageHelper.cs (+6 -60)
📝 MediaBrowser.Controller/Drawing/ImageProcessingOptions.cs (+9 -0)
📝 MediaBrowser.Model/Drawing/DrawingUtils.cs (+46 -0)

📄 Description

Changes

Adds fillHeight and fillWidth optional parameters to all(?) image endpoints.

Issues

Server portion for resolving jellyfin/jellyfin-web#2191

Web PR: jellyfin/jellyfin-web#2514
apiClient PR: jellyfin/jellyfin-apiclient-javascript#167

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5556 **Author:** [@oddstr13](https://github.com/oddstr13) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 4/11/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `image-fill-resize` --- ### 📝 Commits (6) - [`383aa4e`](https://github.com/jellyfin/jellyfin/commit/383aa4e4d9cf4b0997b9277df838728102e0db3c) Add Resize to fill box alternative to image endpoints - [`13d0837`](https://github.com/jellyfin/jellyfin/commit/13d0837b78011925d308e7ff593207b0e1cb330f) (mostly)Fix ResizeFill - [`e57c165`](https://github.com/jellyfin/jellyfin/commit/e57c1655fb2b7d92db33ff3a3b6b09a09b69cf68) Remove GetSizeEstimate & GetEstimatedAspectRatio - [`afff226`](https://github.com/jellyfin/jellyfin/commit/afff226514a6f645a6738f1e407208826b84f1d6) Apply suggestions from code review - [`e0edbc5`](https://github.com/jellyfin/jellyfin/commit/e0edbc5754ad4d6afad1f01874ca2085d4f0791d) Apply suggestions from code review - [`d0857cf`](https://github.com/jellyfin/jellyfin/commit/d0857cf6553ffa9560b42720af04e0b5ebcc9c7f) Fix build, increase StringBuilder starting size ### 📊 Changes **5 files changed** (+253 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Drawing/ImageProcessor.cs` (+96 -17) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+96 -4) 📝 `MediaBrowser.Controller/Drawing/ImageHelper.cs` (+6 -60) 📝 `MediaBrowser.Controller/Drawing/ImageProcessingOptions.cs` (+9 -0) 📝 `MediaBrowser.Model/Drawing/DrawingUtils.cs` (+46 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Adds fillHeight and fillWidth optional parameters to all(?) image endpoints. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Server portion for resolving jellyfin/jellyfin-web#2191 Web PR: jellyfin/jellyfin-web#2514 apiClient PR: jellyfin/jellyfin-apiclient-javascript#167 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?