starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5550] [MERGED] revert underscore as a multiversion separator #10553

New Issue
Closed
opened 2026-02-07 06:22:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5550
Author: @cvium
Created: 3/16/2021
Status: ✅ Merged
Merged: 3/16/2021
Merged by: @Bond-009

Base: master ← Head: revert_underscore_multiversion

📝 Commits (1)

  • 23c3188 revert underscore as a multiversion separator

📊 Changes

2 files changed (+2 additions, -6 deletions)

View changed files

📝 Emby.Naming/Video/VideoListResolver.cs (+0 -1)
📝 tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs (+2 -5)

📄 Description

Changes
Looking at the history of the multi-version eligibility check and accompanying unit tests, it seems that underscore was broken/unsupported for a long time and also missing in all documentation. It seems only fair to revert this particular change as it causes some false positives and I don't see any reason to reserve three different naming schemes.

Issues
Fixes #5528

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5550 **Author:** [@cvium](https://github.com/cvium) **Created:** 3/16/2021 **Status:** ✅ Merged **Merged:** 3/16/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `revert_underscore_multiversion` --- ### 📝 Commits (1) - [`23c3188`](https://github.com/jellyfin/jellyfin/commit/23c3188501447db9def5cd5345112a76cfe04b83) revert underscore as a multiversion separator ### 📊 Changes **2 files changed** (+2 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/Video/VideoListResolver.cs` (+0 -1) 📝 `tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs` (+2 -5) </details> ### 📄 Description **Changes** Looking at the history of the multi-version eligibility check and accompanying unit tests, it seems that underscore was broken/unsupported for a long time and also missing in all documentation. It seems only fair to revert this particular change as it causes some false positives and I don't see any reason to reserve three different naming schemes. **Issues** Fixes #5528 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?