starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5495] [MERGED] Fix remote access whitelist #10540

New Issue
Closed
opened 2026-02-07 06:22:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:22:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5495
Author: @BaronGreenback
Created: 3/12/2021
Status: ✅ Merged
Merged: 3/27/2021
Merged by: @Bond-009

Base: master ← Head: RemoteAccessFix

📝 Commits (10+)

  • 3fdf0de Fix remote access
  • 034ee38 Update Jellyfin.sln
  • f66cb97 Update Jellyfin.Networking/Manager/NetworkManager.cs
  • 3fa8450 Update Jellyfin.Networking/Manager/NetworkManager.cs
  • e5914fd split tests
  • b7fb152 Update tests/Jellyfin.Networking.Tests/NetworkParseTests.cs
  • 4cf88f6 Update NetworkManager.cs
  • 7fa525c Added more tests
  • 5d16d1f Merge branch 'master' into RemoteAccessFix
  • 6765f6a fix compilation

📊 Changes

5 files changed (+93 additions, -43 deletions)

View changed files

📝 Jellyfin.Networking/Manager/NetworkManager.cs (+23 -0)
📝 Jellyfin.Server/Middleware/IpBasedAccessValidationMiddleware.cs (+2 -27)
📝 Jellyfin.sln (+9 -4)
📝 MediaBrowser.Common/Net/INetworkManager.cs (+7 -0)
📝 tests/Jellyfin.Networking.Tests/NetworkParseTests.cs (+52 -12)

📄 Description

Bug is a logic inversion.

Moved the code into the networkManager so that a test function could be added.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5495 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 3/12/2021 **Status:** ✅ Merged **Merged:** 3/27/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `RemoteAccessFix` --- ### 📝 Commits (10+) - [`3fdf0de`](https://github.com/jellyfin/jellyfin/commit/3fdf0de6e3b3600e2825b6ee75634e906d102ce2) Fix remote access - [`034ee38`](https://github.com/jellyfin/jellyfin/commit/034ee38583e613e7dd24282d02051f599b15cedc) Update Jellyfin.sln - [`f66cb97`](https://github.com/jellyfin/jellyfin/commit/f66cb9777ddaf42f19ea452f85c5fa0b7e907391) Update Jellyfin.Networking/Manager/NetworkManager.cs - [`3fa8450`](https://github.com/jellyfin/jellyfin/commit/3fa84500cf7430e3f56f04303e7e150f10e88dfb) Update Jellyfin.Networking/Manager/NetworkManager.cs - [`e5914fd`](https://github.com/jellyfin/jellyfin/commit/e5914fd28c9f5073eeadff6fc6097297837b2544) split tests - [`b7fb152`](https://github.com/jellyfin/jellyfin/commit/b7fb152faf6c01e20d9b8c46be13fc7cc5e0edbc) Update tests/Jellyfin.Networking.Tests/NetworkParseTests.cs - [`4cf88f6`](https://github.com/jellyfin/jellyfin/commit/4cf88f67baf8f76ce4ed630cc73ef73405c0212b) Update NetworkManager.cs - [`7fa525c`](https://github.com/jellyfin/jellyfin/commit/7fa525c83b7573e61124fa1c64a3b27569e66b6d) Added more tests - [`5d16d1f`](https://github.com/jellyfin/jellyfin/commit/5d16d1f66de499022da3eeb484a2cdfe341bed2f) Merge branch 'master' into RemoteAccessFix - [`6765f6a`](https://github.com/jellyfin/jellyfin/commit/6765f6ab172bcb5a6a98ba84087c5b51288f05d7) fix compilation ### 📊 Changes **5 files changed** (+93 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Networking/Manager/NetworkManager.cs` (+23 -0) 📝 `Jellyfin.Server/Middleware/IpBasedAccessValidationMiddleware.cs` (+2 -27) 📝 `Jellyfin.sln` (+9 -4) 📝 `MediaBrowser.Common/Net/INetworkManager.cs` (+7 -0) 📝 `tests/Jellyfin.Networking.Tests/NetworkParseTests.cs` (+52 -12) </details> ### 📄 Description Bug is a logic inversion. Moved the code into the networkManager so that a test function could be added. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:07 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?