[PR #5510] [MERGED] Fix: Streaming crashing due to no deviceProfileId match. #10539

Closed
opened 2026-02-07 06:22:06 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5510
Author: @BaronGreenback
Created: 3/13/2021
Status: Merged
Merged: 3/14/2021
Merged by: @cvium

Base: masterHead: DlnaFirstFix


📝 Commits (1)

  • 1d5b7b6 Change First to FirstOrDefault

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 Emby.Dlna/DlnaManager.cs (+6 -1)

📄 Description

.First crashes the code and returns a Sequence contains no matching element error.

Fixes https://github.com/jellyfin/jellyfin/issues/5509

Am still investigating why deviceProfileId isn't being matched, but given the code it looks like it expected ??!?!?!

            if (!string.IsNullOrWhiteSpace(deviceProfileId))
            {
                state.DeviceProfile = dlnaManager.GetProfile(deviceProfileId);

                if (state.DeviceProfile == null)
                {
                    var caps = deviceManager.GetCapabilities(deviceProfileId);
                    state.DeviceProfile = caps == null ? dlnaManager.GetProfile(request.Headers) : caps.DeviceProfile;
                }
            }

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5510 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 3/13/2021 **Status:** ✅ Merged **Merged:** 3/14/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `DlnaFirstFix` --- ### 📝 Commits (1) - [`1d5b7b6`](https://github.com/jellyfin/jellyfin/commit/1d5b7b61fb002dd4b2e3fe4cf8dd02df590f64e7) Change First to FirstOrDefault ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/DlnaManager.cs` (+6 -1) </details> ### 📄 Description .First crashes the code and returns a `Sequence contains no matching element error.` Fixes https://github.com/jellyfin/jellyfin/issues/5509 Am still investigating why deviceProfileId isn't being matched, but given the code it looks like it expected ??!?!?! ``` if (!string.IsNullOrWhiteSpace(deviceProfileId)) { state.DeviceProfile = dlnaManager.GetProfile(deviceProfileId); if (state.DeviceProfile == null) { var caps = deviceManager.GetCapabilities(deviceProfileId); state.DeviceProfile = caps == null ? dlnaManager.GetProfile(request.Headers) : caps.DeviceProfile; } } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:22:06 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10539