starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #5455] [CLOSED] Centralise CultureInfo #10531

New Issue
Closed
opened 2026-02-07 06:21:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:21:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5455
Author: @BaronGreenback
Created: 3/10/2021
Status: ❌ Closed

Base: master ← Head: CurrentCulture

📝 Commits (7)

📊 Changes

22 files changed (+154 additions, -148 deletions)

View changed files

📝 Emby.Dlna/Didl/DidlBuilder.cs (+14 -15)
📝 Emby.Dlna/Eventing/DlnaEventManager.cs (+4 -5)
📝 Emby.Dlna/PlayTo/Device.cs (+6 -7)
📝 Emby.Dlna/PlayTo/PlayToController.cs (+4 -5)
📝 Emby.Dlna/PlayTo/SsdpHttpClient.cs (+4 -5)
📝 Emby.Dlna/Server/DescriptionXmlBuilder.cs (+3 -3)
📝 Emby.Server.Implementations/MediaEncoder/EncodingManager.cs (+2 -2)
📝 Jellyfin.Api/Controllers/ImageController.cs (+2 -1)
➕ MediaBrowser.Common/Culture/CultureDefault.cs (+20 -0)
📝 MediaBrowser.Controller/Entities/Year.cs (+2 -3)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+21 -22)
📝 MediaBrowser.Controller/MediaEncoding/JobLogger.cs (+6 -6)
📝 MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs (+2 -3)
📝 MediaBrowser.LocalMetadata/Parsers/BaseItemXmlParser.cs (+4 -5)
📝 MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs (+7 -7)
📝 MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs (+4 -8)
📝 MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs (+13 -13)
📝 MediaBrowser.Providers/Manager/ImageSaver.cs (+9 -10)
📝 MediaBrowser.Providers/Plugins/Omdb/OmdbProvider.cs (+7 -7)
📝 MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs (+5 -6)

...and 2 more files

📄 Description

Noticed we had numerous creations of CultureInfo of en-US.

This PR centralised to a single instance in similar to that of json, and should save some memory as most were static.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5455 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 3/10/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `CurrentCulture` --- ### 📝 Commits (7) - [`0f80381`](https://github.com/jellyfin/jellyfin/commit/0f80381820b1ef922424c31387269775d85fc7a1) Centralise CultureInfo - [`35a708f`](https://github.com/jellyfin/jellyfin/commit/35a708f5579d2f6fde41f57dac138bebaaaa7cd4) Make readonly - [`f984050`](https://github.com/jellyfin/jellyfin/commit/f9840507fbb7dab0c2991ba22f1441b394716159) Changed case of variable - [`f56d325`](https://github.com/jellyfin/jellyfin/commit/f56d3251963985a5a98a57c5cb599b85f7aa14dc) Merge branch 'master' into CurrentCulture - [`f786ba9`](https://github.com/jellyfin/jellyfin/commit/f786ba9c9e99c7827b39d92469256e51c5e11b89) fixed merge - [`ba2e0f7`](https://github.com/jellyfin/jellyfin/commit/ba2e0f71d6fa9c2b7cf9003caf3286e6d1364cc1) Merge branch 'master' into CurrentCulture - [`6a18ba8`](https://github.com/jellyfin/jellyfin/commit/6a18ba84786248ca017e10f2961c7eb07cb44032) fixed merge ### 📊 Changes **22 files changed** (+154 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Didl/DidlBuilder.cs` (+14 -15) 📝 `Emby.Dlna/Eventing/DlnaEventManager.cs` (+4 -5) 📝 `Emby.Dlna/PlayTo/Device.cs` (+6 -7) 📝 `Emby.Dlna/PlayTo/PlayToController.cs` (+4 -5) 📝 `Emby.Dlna/PlayTo/SsdpHttpClient.cs` (+4 -5) 📝 `Emby.Dlna/Server/DescriptionXmlBuilder.cs` (+3 -3) 📝 `Emby.Server.Implementations/MediaEncoder/EncodingManager.cs` (+2 -2) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+2 -1) ➕ `MediaBrowser.Common/Culture/CultureDefault.cs` (+20 -0) 📝 `MediaBrowser.Controller/Entities/Year.cs` (+2 -3) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+21 -22) 📝 `MediaBrowser.Controller/MediaEncoding/JobLogger.cs` (+6 -6) 📝 `MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs` (+2 -3) 📝 `MediaBrowser.LocalMetadata/Parsers/BaseItemXmlParser.cs` (+4 -5) 📝 `MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs` (+7 -7) 📝 `MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs` (+4 -8) 📝 `MediaBrowser.MediaEncoding/Probing/ProbeResultNormalizer.cs` (+13 -13) 📝 `MediaBrowser.Providers/Manager/ImageSaver.cs` (+9 -10) 📝 `MediaBrowser.Providers/Plugins/Omdb/OmdbProvider.cs` (+7 -7) 📝 `MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs` (+5 -6) _...and 2 more files_ </details> ### 📄 Description Noticed we had numerous creations of CultureInfo of en-US. This PR centralised to a single instance in similar to that of json, and should save some memory as most were static. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:21:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?