starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5321] [MERGED] Add nfo thumb tag support #10481

New Issue
Closed
opened 2026-02-07 06:21:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:21:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5321
Author: @daullmer
Created: 2/28/2021
Status: ✅ Merged
Merged: 3/25/2021
Merged by: @Bond-009

Base: master ← Head: nfo-thumb

📝 Commits (5)

  • 16694b0 Add nfo thumb tag support
  • 6f89814 Use Uri.TryCreate and ImageType helper method
  • b8d52da Update MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs
  • 572600b Use conditional operator instead of if/else block
  • a4cac09 Use |=

📊 Changes

25 files changed (+269 additions, -50 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+2 -0)
📝 MediaBrowser.Controller/Providers/MetadataResult.cs (+8 -4)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+15 -9)
📝 MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs (+82 -1)
📝 MediaBrowser.XbmcMetadata/Parsers/EpisodeNfoParser.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Parsers/MovieNfoParser.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Parsers/SeasonNfoParser.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Parsers/SeriesNfoParser.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Providers/AlbumNfoProvider.cs (+6 -2)
📝 MediaBrowser.XbmcMetadata/Providers/ArtistNfoProvider.cs (+6 -2)
📝 MediaBrowser.XbmcMetadata/Providers/BaseVideoNfoProvider.cs (+7 -2)
📝 MediaBrowser.XbmcMetadata/Providers/EpisodeNfoProvider.cs (+6 -2)
📝 MediaBrowser.XbmcMetadata/Providers/MovieNfoProvider.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Providers/MusicVideoNfoProvider.cs (+4 -2)
📝 MediaBrowser.XbmcMetadata/Providers/SeasonNfoProvider.cs (+6 -2)
📝 MediaBrowser.XbmcMetadata/Providers/SeriesNfoProvider.cs (+6 -2)
📝 MediaBrowser.XbmcMetadata/Providers/VideoNfoProvider.cs (+4 -2)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs (+9 -2)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs (+52 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs (+8 -3)

...and 5 more files

📄 Description

Changes
Add support for nfo thumb tag including tests.

  • Only the first thumb tag for each artwork type is used because only one image for each artwork type is supported.
  • Artwork defined in the nfo file takes precedence over local images in the media folder and provider images.

I would like to document this somewhere but don't know where the right place would be.

Issues
<thumb> part of #5262

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5321 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 2/28/2021 **Status:** ✅ Merged **Merged:** 3/25/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `nfo-thumb` --- ### 📝 Commits (5) - [`16694b0`](https://github.com/jellyfin/jellyfin/commit/16694b0cfcc51ba009a0aedce0d383ab010e8b99) Add nfo thumb tag support - [`6f89814`](https://github.com/jellyfin/jellyfin/commit/6f898145afe013d7dfcd47fbc6adab9316e2dd63) Use Uri.TryCreate and ImageType helper method - [`b8d52da`](https://github.com/jellyfin/jellyfin/commit/b8d52dafa9047403cb7bde221baf9d39baf24e18) Update MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs - [`572600b`](https://github.com/jellyfin/jellyfin/commit/572600b38ec560ee57e9954e2967014a042a1c06) Use conditional operator instead of if/else block - [`a4cac09`](https://github.com/jellyfin/jellyfin/commit/a4cac09d5b90dda5b7d7978e083676394022ffc1) Use |= ### 📊 Changes **25 files changed** (+269 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+2 -0) 📝 `MediaBrowser.Controller/Providers/MetadataResult.cs` (+8 -4) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+15 -9) 📝 `MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs` (+82 -1) 📝 `MediaBrowser.XbmcMetadata/Parsers/EpisodeNfoParser.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Parsers/MovieNfoParser.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Parsers/SeasonNfoParser.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Parsers/SeriesNfoParser.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/AlbumNfoProvider.cs` (+6 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/ArtistNfoProvider.cs` (+6 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/BaseVideoNfoProvider.cs` (+7 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/EpisodeNfoProvider.cs` (+6 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/MovieNfoProvider.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/MusicVideoNfoProvider.cs` (+4 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/SeasonNfoProvider.cs` (+6 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/SeriesNfoProvider.cs` (+6 -2) 📝 `MediaBrowser.XbmcMetadata/Providers/VideoNfoProvider.cs` (+4 -2) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs` (+9 -2) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs` (+52 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs` (+8 -3) _...and 5 more files_ </details> ### 📄 Description **Changes** Add support for nfo thumb tag including tests. - Only the first thumb tag for each artwork type is used because only one image for each artwork type is supported. - Artwork defined in the nfo file takes precedence over local images in the media folder and provider images. I would like to document this somewhere but don't know where the right place would be. **Issues** `<thumb>` part of #5262 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:21:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?