starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5315] [MERGED] Fix for environment variable JELLYFIN_PublishedServerUrl being ignored. #10475

New Issue
Closed
opened 2026-02-07 06:21:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:21:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5315
Author: @BaronGreenback
Created: 2/27/2021
Status: ✅ Merged
Merged: 3/9/2021
Merged by: @joshuaboniface

Base: master ← Head: FixFor5280Part2

📝 Commits (7)

📊 Changes

9 files changed (+38 additions, -19 deletions)

View changed files

📝 Emby.Dlna/Main/DlnaEntryPoint.cs (+1 -1)
📝 Emby.Server.Implementations/ApplicationHost.cs (+17 -9)
📝 Emby.Server.Implementations/IStartupOptions.cs (+6 -6)
📝 Jellyfin.Server/CoreAppHost.cs (+4 -0)
📝 Jellyfin.Server/Program.cs (+1 -0)
📝 Jellyfin.Server/StartupOptions.cs (+2 -2)
📝 MediaBrowser.Controller/IServerApplicationHost.cs (+1 -1)
📝 tests/Jellyfin.Api.Tests/JellyfinApplicationFactory.cs (+2 -0)
📝 tests/Jellyfin.Api.Tests/TestAppHost.cs (+4 -0)

📄 Description

Fix for the second bug reported at https://github.com/jellyfin/jellyfin/issues/5280.

GetSmartApiUrl and elsewhere reference _startupConfig.PublishedServerUrl however, this is only populated via the command-line and not via the environmental variables due to how the IConfigurationBuilder is initialised.

The result is that JELLYFIN_PublishedServerUrl as specified at https://jellyfin.org/docs/general/administration/configuration.html doesn't work.

With this PR, PublishedServerUrl returns the correct value, with the command-line taking precedent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5315 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 2/27/2021 **Status:** ✅ Merged **Merged:** 3/9/2021 **Merged by:** [@joshuaboniface](https://github.com/joshuaboniface) **Base:** `master` ← **Head:** `FixFor5280Part2` --- ### 📝 Commits (7) - [`f666b7e`](https://github.com/jellyfin/jellyfin/commit/f666b7e10268a5c19228d8fdb1bd313a642b0915) fix - [`1d6f489`](https://github.com/jellyfin/jellyfin/commit/1d6f489f17919e557987b2616048dc8def790f43) comment change - [`80ca3da`](https://github.com/jellyfin/jellyfin/commit/80ca3da55c7d8ec9cf06a619fc895c1e427c45ff) Merge remote-tracking branch 'upstream/master' into FixFor5280Part2 - [`159ecb8`](https://github.com/jellyfin/jellyfin/commit/159ecb882f419e485a95e727b647f0e2cf6eeb3d) Fixed bad sync - [`caa8e7c`](https://github.com/jellyfin/jellyfin/commit/caa8e7cdf37a426b983792077542ef0bb50721a7) fixed build - [`8836242`](https://github.com/jellyfin/jellyfin/commit/8836242559710cbe4577451c65f91133c3da4a79) fixed tests - [`d339030`](https://github.com/jellyfin/jellyfin/commit/d3390302f9c3d62bb9c878f52cf11f9f00438cb1) Update ApplicationHost.cs ### 📊 Changes **9 files changed** (+38 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Dlna/Main/DlnaEntryPoint.cs` (+1 -1) 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+17 -9) 📝 `Emby.Server.Implementations/IStartupOptions.cs` (+6 -6) 📝 `Jellyfin.Server/CoreAppHost.cs` (+4 -0) 📝 `Jellyfin.Server/Program.cs` (+1 -0) 📝 `Jellyfin.Server/StartupOptions.cs` (+2 -2) 📝 `MediaBrowser.Controller/IServerApplicationHost.cs` (+1 -1) 📝 `tests/Jellyfin.Api.Tests/JellyfinApplicationFactory.cs` (+2 -0) 📝 `tests/Jellyfin.Api.Tests/TestAppHost.cs` (+4 -0) </details> ### 📄 Description Fix for the second bug reported at https://github.com/jellyfin/jellyfin/issues/5280. _GetSmartApiUrl_ and elsewhere reference __startupConfig.PublishedServerUrl_ however, this is only populated via the command-line and not via the environmental variables due to how the _IConfigurationBuilder_ is initialised. The result is that JELLYFIN_PublishedServerUrl as specified at https://jellyfin.org/docs/general/administration/configuration.html doesn't work. With this PR, PublishedServerUrl returns the correct value, with the command-line taking precedent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:21:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?