starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5274] [MERGED] Fix for #5254 #10453

New Issue
Closed
opened 2026-02-07 06:20:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:20:40 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5274
Author: @BaronGreenback
Created: 2/21/2021
Status: ✅ Merged
Merged: 2/28/2021
Merged by: @cvium

Base: master ← Head: bindfix

📝 Commits (10+)

  • 605bd80 Fix for ignoreVirtualInterfaces
  • b03bd7a Fix testing
  • cb09096 optimized
  • 5756c6d Merge branch 'master' into bindfix
  • 7bfc59b Fixed test data.
  • ff7cae8 renamed method
  • f671370 Update Jellyfin.Networking/Manager/NetworkManager.cs
  • b5c6e5f Update Jellyfin.Networking/Manager/NetworkManager.cs
  • 039a4fb renamed method
  • d99d954 Update Jellyfin.Networking/Manager/NetworkManager.cs

📊 Changes

2 files changed (+30 additions, -16 deletions)

View changed files

📝 Jellyfin.Networking/Manager/NetworkManager.cs (+23 -14)
📝 tests/Jellyfin.Networking.Tests/NetworkTesting/NetworkParseTests.cs (+7 -2)

📄 Description

Fix1: (#5254) The virtual interface detection routine is supposed to add the interface names defined in the list to the excluded bind list. eg. vEthernet* excludes an interfaces starting with vEthernet.

However, as the excluded interface name is not prefixed with ! it is ignored, and is instead added to the list of bind interfaces.

This PR corrects the problem by prepending the virtual interface name upon which to match with a "!" so that it will be processed correctly.

Fix2: When there were multiple virtual interfaces, only the first that matched was processed. All are now processed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5274 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 2/21/2021 **Status:** ✅ Merged **Merged:** 2/28/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `bindfix` --- ### 📝 Commits (10+) - [`605bd80`](https://github.com/jellyfin/jellyfin/commit/605bd80251368a88f7ffc0d0442bd52a7575329a) Fix for ignoreVirtualInterfaces - [`b03bd7a`](https://github.com/jellyfin/jellyfin/commit/b03bd7a29935895c7d11507e59008df0eb5ba58c) Fix testing - [`cb09096`](https://github.com/jellyfin/jellyfin/commit/cb09096a59c0df9b02f4c057db93d8479678af8f) optimized - [`5756c6d`](https://github.com/jellyfin/jellyfin/commit/5756c6dbad8734171ee539e1a73d15c907168d93) Merge branch 'master' into bindfix - [`7bfc59b`](https://github.com/jellyfin/jellyfin/commit/7bfc59b562b2a266e184d76c92a2af56377dfb5c) Fixed test data. - [`ff7cae8`](https://github.com/jellyfin/jellyfin/commit/ff7cae8a13ce4bd5f158da840907a46ef2ad7d86) renamed method - [`f671370`](https://github.com/jellyfin/jellyfin/commit/f67137004c16fc8bf2478e9898e786599469c465) Update Jellyfin.Networking/Manager/NetworkManager.cs - [`b5c6e5f`](https://github.com/jellyfin/jellyfin/commit/b5c6e5fb97d06533583f8273227f9215906c2ed1) Update Jellyfin.Networking/Manager/NetworkManager.cs - [`039a4fb`](https://github.com/jellyfin/jellyfin/commit/039a4fb22d52d840019ecdb39c62bcd7f76e3b84) renamed method - [`d99d954`](https://github.com/jellyfin/jellyfin/commit/d99d95422ed52bd3a7dbf9f7bd947feb809a2616) Update Jellyfin.Networking/Manager/NetworkManager.cs ### 📊 Changes **2 files changed** (+30 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Networking/Manager/NetworkManager.cs` (+23 -14) 📝 `tests/Jellyfin.Networking.Tests/NetworkTesting/NetworkParseTests.cs` (+7 -2) </details> ### 📄 Description **Fix1:** (#5254) The virtual interface detection routine is supposed to add the interface names defined in the list to the excluded bind list. eg. vEthernet* excludes an interfaces starting with vEthernet. However, as the excluded interface name is not prefixed with ! it is ignored, and is instead added to the list of bind interfaces. This PR corrects the problem by prepending the virtual interface name upon which to match with a "!" so that it will be processed correctly. **Fix2:** When there were multiple virtual interfaces, only the first that matched was processed. All are now processed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:20:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10453
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?