[PR #5193] [MERGED] Add test for generic nfo provider id parsing #10426

New Issue

OVERLORD · 2026-02-07T06:20:06+03:00

OVERLORD commented

2026-02-07 06:20:06 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5193
Author: @daullmer
Created: 2/9/2021
Status: ✅ Merged
Merged: 2/9/2021
Merged by: @Bond-009

Base: master ← Head: nfo-id-test

📝 Commits (1)

0862548 Add test for generic nfo provider id parsing

📊 Changes

9 files changed (+38 additions, -21 deletions)

View changed files

📝 MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs (+0 -14)
📝 tests/Jellyfin.XbmcMetadata.Tests/Jellyfin.XbmcMetadata.Tests.csproj (+1 -0)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs (+9 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs (+9 -2)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs (+8 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicArtistNfoParserTests.cs (+7 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeriesNfoParserTests.cs (+2 -2)
📝 tests/Jellyfin.XbmcMetadata.Tests/Test Data/Justice League.nfo (+1 -0)
📝 tests/Jellyfin.XbmcMetadata.Tests/Test Data/The Bone Orchard.nfo (+1 -0)

📄 Description

Changes

remove case "musicBrainzArtistID": from nfo parser because ids are handled dynamically
add additional id tags for movies and episodes and test parsing for them

Issues

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5193 **Author:** [@daullmer](https://github.com/daullmer) **Created:** 2/9/2021 **Status:** ✅ Merged **Merged:** 2/9/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `nfo-id-test` --- ### 📝 Commits (1) - [`0862548`](https://github.com/jellyfin/jellyfin/commit/086254821ffbcaf6321f7e4fada419e6ee3174c6) Add test for generic nfo provider id parsing ### 📊 Changes **9 files changed** (+38 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.XbmcMetadata/Parsers/BaseNfoParser.cs` (+0 -14) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Jellyfin.XbmcMetadata.Tests.csproj` (+1 -0) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs` (+9 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs` (+9 -2) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs` (+8 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicArtistNfoParserTests.cs` (+7 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeriesNfoParserTests.cs` (+2 -2) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Test Data/Justice League.nfo` (+1 -0) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Test Data/The Bone Orchard.nfo` (+1 -0) </details> ### 📄 Description **Changes** - remove `case "musicBrainzArtistID":` from nfo parser because ids are handled dynamically - add additional id tags for movies and episodes and test parsing for them **Issues**  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 06:20:06 +03:00

OVERLORD closed this issue

2026-02-07 06:20:07 +03:00

OVERLORD referenced this issue

2026-02-07 06:56:42 +03:00

[PR #10426] LibraryManager Refactor #12482

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10426