starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5166] [MERGED] Get episode range end from XBMC compatible nfo #10416

New Issue
Closed
opened 2026-02-07 06:19:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:19:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5166
Author: @netpok
Created: 2/5/2021
Status: ✅ Merged
Merged: 2/23/2021
Merged by: @Bond-009

Base: master ← Head: index-number-end-from-nfo

📝 Commits (6)

📊 Changes

8 files changed (+72 additions, -9 deletions)

View changed files

📝 MediaBrowser.XbmcMetadata/Parsers/EpisodeNfoParser.cs (+26 -3)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs (+21 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs (+1 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs (+1 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicArtistNfoParserTests.cs (+1 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeasonNfoProviderTests.cs (+1 -1)
📝 tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeriesNfoParserTests.cs (+1 -1)
➕ tests/Jellyfin.XbmcMetadata.Tests/Test Data/Rising.nfo (+20 -0)

📄 Description

Changes
This PR allows parsing the end of multiepisode file from XBMC compatible nfo. This is required because the nfo contains each episode in a root block.

For example:
Stargate Atlantis - 1x01-02:

<episodedetails>
  <title>Rising (1)</title>
  <season>1</season>
  <episode>1</episode>
  ...
</episodedetails>
<episodedetails>
  <title>Rising (2)</title>
  <season>1</season>
  <episode>2</episode>
  ...
</episodedetails>

This resulted the file being parsed as episode 1 instead of episode 1-2.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5166 **Author:** [@netpok](https://github.com/netpok) **Created:** 2/5/2021 **Status:** ✅ Merged **Merged:** 2/23/2021 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `index-number-end-from-nfo` --- ### 📝 Commits (6) - [`b646787`](https://github.com/jellyfin/jellyfin/commit/b646787ab6cae179e2e31f05bbdfd9201c7d1a69) Get IndexNumberEnd from nfo - [`094ffaf`](https://github.com/jellyfin/jellyfin/commit/094ffafb249e454f8e71279f8aa0693a17990e1e) Comment and simplify code - [`351d61a`](https://github.com/jellyfin/jellyfin/commit/351d61a3181c6caf217ec74eed37f972190b624d) Add test for multiepisode nfo parsing - [`c97edc9`](https://github.com/jellyfin/jellyfin/commit/c97edc96eb432940fb7352165c644bab4d6d0dda) Fix typo - [`7ba5354`](https://github.com/jellyfin/jellyfin/commit/7ba53548a2ed07cf3b6b4692ddd79df9d85edf63) Fix typos in nfo tests - [`a015cab`](https://github.com/jellyfin/jellyfin/commit/a015caba3f7089c17b4c675a124c2a46c493b4ed) Remove unnecessary sanity check ### 📊 Changes **8 files changed** (+72 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.XbmcMetadata/Parsers/EpisodeNfoParser.cs` (+26 -3) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/EpisodeNfoProviderTests.cs` (+21 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MovieNfoParserTests.cs` (+1 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicAlbumNfoProviderTests.cs` (+1 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/MusicArtistNfoParserTests.cs` (+1 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeasonNfoProviderTests.cs` (+1 -1) 📝 `tests/Jellyfin.XbmcMetadata.Tests/Parsers/SeriesNfoParserTests.cs` (+1 -1) ➕ `tests/Jellyfin.XbmcMetadata.Tests/Test Data/Rising.nfo` (+20 -0) </details> ### 📄 Description **Changes** This PR allows parsing the end of multiepisode file from XBMC compatible nfo. This is required because the nfo contains each episode in a root block. For example: Stargate Atlantis - 1x01-02: ``` <episodedetails> <title>Rising (1)</title> <season>1</season> <episode>1</episode> ... </episodedetails> <episodedetails> <title>Rising (2)</title> <season>1</season> <episode>2</episode> ... </episodedetails> ``` This resulted the file being parsed as episode 1 instead of episode 1-2. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:19:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?