starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #5111] [MERGED] Remove season name from metadata result #10407

New Issue
Closed
opened 2026-02-07 06:19:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:19:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5111
Author: @Zura-01
Created: 1/26/2021
Status: ✅ Merged
Merged: 2/3/2021
Merged by: @cvium

Base: master ← Head: tmdb-season-name-fix

📝 Commits (1)

  • 0d1f356 Remove season name from metadata result

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonProvider.cs (+0 -1)

📄 Description

A copy of: https://github.com/jellyfin/jellyfin-plugin-tmdb/pull/1

Apparently TMDB season provider copies SeasonInfo.Name to MetadataResult which:

  1. Does not really make sense. In this case we should not return name at all.
  2. Causes an issue where all season names would be replaced with series name.

Root cause of this issue is in Jellyfin itself which for some reason sets SeasonInfo.Name to series name when sending it to GetMetadata but anyways I don't think we should copy anything from SeasonInfo to MetadataResult even if name was correctly set to 'Season X'.

Probably it was originally set to Name = seasonResult.Name but someone did not like whatever TMDbLib returned here so it was changed to info.Name. Quote from jellyfin#10.6.z:

// Don't use moviedb season names for now until if/when we have field-level configuration
// result.Item.Name = seasonInfo.name;

Changes
Do not return season name at all.

Issues
Should fix:
https://github.com/jellyfin/jellyfin/issues/4948
https://github.com/jellyfin/jellyfin/issues/4134

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5111 **Author:** [@Zura-01](https://github.com/Zura-01) **Created:** 1/26/2021 **Status:** ✅ Merged **Merged:** 2/3/2021 **Merged by:** [@cvium](https://github.com/cvium) **Base:** `master` ← **Head:** `tmdb-season-name-fix` --- ### 📝 Commits (1) - [`0d1f356`](https://github.com/jellyfin/jellyfin/commit/0d1f3563735d8ce212080719345fdd4afc835bb5) Remove season name from metadata result ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonProvider.cs` (+0 -1) </details> ### 📄 Description A copy of: https://github.com/jellyfin/jellyfin-plugin-tmdb/pull/1 Apparently TMDB season provider copies `SeasonInfo.Name` to `MetadataResult` which: 1. Does not really make sense. In this case we should not return name at all. 2. Causes an issue where all season names would be replaced with series name. Root cause of this issue is in Jellyfin itself which for some reason sets `SeasonInfo.Name` to series name when sending it to `GetMetadata` but anyways I don't think we should copy anything from `SeasonInfo` to `MetadataResult` even if name was correctly set to 'Season X'. Probably it was originally set to `Name = seasonResult.Name` but someone did not like whatever TMDbLib returned here so it was changed to `info.Name`. Quote from [jellyfin#10.6.z](https://github.com/jellyfin/jellyfin/blob/release-10.6.z/MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonProvider.cs): > // Don't use moviedb season names for now until if/when we have field-level configuration > // result.Item.Name = seasonInfo.name; **Changes** Do not return season name at all. **Issues** Should fix: https://github.com/jellyfin/jellyfin/issues/4948 https://github.com/jellyfin/jellyfin/issues/4134 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 06:19:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#10407
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?